From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 4/7] Use lstat unconditionally
Date: Wed, 26 Nov 2014 05:47:00 -0000 [thread overview]
Message-ID: <1416980800-21408-5-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1416980800-21408-1-git-send-email-yao@codesourcery.com>
Since lstat gnulib module is imported, we can use it unconditionally.
lstat usage was introduced by this patch
https://sourceware.org/ml/gdb-patches/2012-01/msg00390.html
during the review, it was suggested to import gnulib lstat module, but
we didn't do that.
gdb:
2014-11-26 Yao Qi <yao@codesourcery.com>
* configure.ac (AC_CHECK_FUNCS): Remove lstat.
* config.in, configure: Regenerate.
* symfile.c (find_separate_debug_file_by_debuglink): Remove
code checking HAVE_LSTAT is defined.
---
gdb/config.in | 3 ---
gdb/configure | 2 +-
gdb/configure.ac | 2 +-
gdb/symfile.c | 2 --
4 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/gdb/config.in b/gdb/config.in
index 80b988b..8c5a710 100644
--- a/gdb/config.in
+++ b/gdb/config.in
@@ -225,9 +225,6 @@
/* Define to 1 if the compiler supports long double. */
#undef HAVE_LONG_DOUBLE
-/* Define to 1 if you have the `lstat' function. */
-#undef HAVE_LSTAT
-
/* Define if <sys/procfs.h> has lwpid_t. */
#undef HAVE_LWPID_T
diff --git a/gdb/configure b/gdb/configure
index e1c0a10..0c04eba 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -10483,7 +10483,7 @@ for ac_func in canonicalize_file_name realpath getrusage getuid getgid \
sbrk setpgid setpgrp setsid \
sigaction sigprocmask sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
- setrlimit getrlimit posix_madvise waitpid lstat \
+ setrlimit getrlimit posix_madvise waitpid \
ptrace64 sigaltstack
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
diff --git a/gdb/configure.ac b/gdb/configure.ac
index bcf1ef2..f8c32ad 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1309,7 +1309,7 @@ AC_CHECK_FUNCS([canonicalize_file_name realpath getrusage getuid getgid \
sbrk setpgid setpgrp setsid \
sigaction sigprocmask sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
- setrlimit getrlimit posix_madvise waitpid lstat \
+ setrlimit getrlimit posix_madvise waitpid \
ptrace64 sigaltstack])
AM_LANGINFO_CODESET
GDB_AC_COMMON
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 29877ec..a09ebe6 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -1591,7 +1591,6 @@ find_separate_debug_file_by_debuglink (struct objfile *objfile)
if (debugfile == NULL)
{
-#ifdef HAVE_LSTAT
/* For PR gdb/9538, try again with realpath (if different from the
original). */
@@ -1618,7 +1617,6 @@ find_separate_debug_file_by_debuglink (struct objfile *objfile)
}
}
}
-#endif /* HAVE_LSTAT */
}
do_cleanups (cleanups);
--
1.9.3
next prev parent reply other threads:[~2014-11-26 5:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 5:46 [PATCH 0/7 V2] Import the rename gnulib module Yao Qi
2014-11-26 5:46 ` [PATCH 2/7] Use readlink unconditionally Yao Qi
2014-11-26 5:46 ` [PATCH 1/7] Import readlink Yao Qi
2014-12-03 10:48 ` Joel Brobecker
2014-12-03 12:08 ` [RFA] configure gdb/gnulib with --disable-largefile if largefile support disabled Joel Brobecker
2014-12-03 17:59 ` Eli Zaretskii
2014-12-04 3:18 ` Joel Brobecker
2014-12-04 6:47 ` Eli Zaretskii
2014-12-13 16:29 ` Joel Brobecker
2014-12-04 2:17 ` Yao Qi
2014-12-13 14:46 ` pushed: " Joel Brobecker
2014-11-26 5:47 ` [PATCH 6/7] Use canonicalize_file_name unconditionally Yao Qi
2014-11-27 7:36 ` Joel Brobecker
2014-11-28 3:07 ` Yao Qi
2014-11-28 3:43 ` Joel Brobecker
2014-11-28 10:43 ` Yao Qi
2014-11-28 14:46 ` Joel Brobecker
2014-11-26 5:47 ` Yao Qi [this message]
2014-11-26 5:47 ` [PATCH 7/7] Import rename module Yao Qi
2014-11-26 5:47 ` [PATCH 5/7] Import canonicalize-lgpl Yao Qi
2014-11-26 5:47 ` [PATCH 3/7] Import lstat Yao Qi
2014-12-02 17:01 ` Joel Brobecker
2014-12-03 9:48 ` [pushed] callback.h:struct host_callback_struct compilation error on Windows hosts Joel Brobecker
2014-12-04 1:09 ` Yao Qi
2014-12-04 5:42 ` Joel Brobecker
2014-11-26 15:40 ` [PATCH 0/7 V2] Import the rename gnulib module Eli Zaretskii
2014-11-27 3:48 ` Yao Qi
2014-11-27 7:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416980800-21408-5-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).