From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [pushed] gdb/python: exception trying to create empty array
Date: Tue, 06 Jan 2015 15:09:00 -0000 [thread overview]
Message-ID: <1420556955-13827-1-git-send-email-brobecker@adacore.com> (raw)
Hello,
The following python command fails:
(gdb) python print gdb.lookup_type('char').array(1, 0)
Traceback (most recent call last):
File "<string>", line 1, in <module>
ValueError: Array length must not be negative
Error while executing Python code.
The above is trying to create an empty array, which is fairly command
in Ada.
gdb/ChangeLog:
* python/py-type.c (typy_array_1): Do not raise negative-length
exception if N2 is equal to N1 - 1.
gdb/testsuite/ChangeLog:
* gdb.python/py-type.exp: Add a couple test about empty
array creation, and negative-length array creation.
Tested on x86_64-linux, no regression. Pushed a obvious.
Thank you,
--
Joel
PS: There is the same error in guile, and I will push a patch
momentarily.
---
gdb/ChangeLog | 5 +++++
gdb/python/py-type.c | 2 +-
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.python/py-type.exp | 6 ++++++
4 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b3e1263..a6211bf 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-01-06 Joel Brobecker <brobecker@adacore.com>
+
+ * python/py-type.c (typy_array_1): Do not raise negative-length
+ exception if N2 is equal to N1 - 1.
+
2015-01-03 Doug Evans <xdje42@gmail.com>
* c-exp.y: Whitespace cleanup.
diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
index 54fc30f..8e82c99 100644
--- a/gdb/python/py-type.c
+++ b/gdb/python/py-type.c
@@ -528,7 +528,7 @@ typy_array_1 (PyObject *self, PyObject *args, int is_vector)
n1 = 0;
}
- if (n2 < n1)
+ if (n2 < n1 - 1)
{
PyErr_SetString (PyExc_ValueError,
_("Array length must not be negative"));
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 374c285..7db0809 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-01-06 Joel Brobecker <brobecker@adacore.com>
+
+ * gdb.python/py-type.exp: Add a couple test about empty
+ array creation, and negative-length array creation.
+
2015-01-02 Doug Evans <xdje42@gmail.com>
* gdb.cp/nsalias.exp: Fix output of external/declaration flags.
diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp
index 90de68d..c4c8d9f 100644
--- a/gdb/testsuite/gdb.python/py-type.exp
+++ b/gdb/testsuite/gdb.python/py-type.exp
@@ -247,6 +247,12 @@ restart_gdb "${binfile}"
# Skip all tests if Python scripting is not enabled.
if { [skip_python_tests] } { continue }
+gdb_test "python print gdb.lookup_type('char').array(1, 0)" \
+ "char \\\[0\\\]"
+
+gdb_test "python print gdb.lookup_type('char').array(1, -1)" \
+ "Array length must not be negative.*"
+
with_test_prefix "lang_c" {
runto_bp "break to inspect struct and array."
test_fields "c"
--
1.9.1
next reply other threads:[~2015-01-06 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 15:09 Joel Brobecker [this message]
2015-01-06 18:52 ` Doug Evans
2015-01-07 3:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420556955-13827-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).