From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24176 invoked by alias); 13 Jan 2015 15:33:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24135 invoked by uid 89); 13 Jan 2015 15:33:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 13 Jan 2015 15:32:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A49471162F7 for ; Tue, 13 Jan 2015 10:32:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8bcW9zDWF0n6 for ; Tue, 13 Jan 2015 10:32:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2F9E21162BD for ; Tue, 13 Jan 2015 10:32:53 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B293648E8B; Tue, 13 Jan 2015 19:32:48 +0400 (RET) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [pushed/master/gdb-7.9-branch] gdb/testsuite: Make clean mostlyclean should not delete *.py. Date: Tue, 13 Jan 2015 15:33:00 -0000 Message-Id: <1421163167-17428-1-git-send-email-brobecker@adacore.com> X-SW-Source: 2015-01/txt/msg00341.txt.bz2 Hello, A sanity-check in my release scripts caught something: After having created the tarballs, I verify that no checked-in file disappeared in the process, and lo and behod, it found that the following file got wiped: - gdb/testsuite/dg-extract-results.py: And it's not part of the tarball either. I don't understand while we delete all *.py files in gdb/testsuite, since I don't see a rule that expected to create one. A run of the testsuite also doesn't seem to be creating .py files there. I traced this to the following commit, which unfortunately provided no explanation. Perhaps we used to run some tests in the gdb/testsuite directory and caused files to be left behind there. Perhaps we still do today? In the meantime, Executive Decision: In order to allow me to create tarballs without losing files, I removed it. It's easy to put something back if we find out why it might still be needed. gdb/testsuite/ChangeLog: * Makefile.in (clean mostlyclean): Do not delete *.py. Tested on x86_64-linux by running the src-release.sh script again, and this time, dg-extract-results.py no longer gets wiped. I am completely comfortable with the idea of this change not being correct, or needing a tweak. It's not a great harm, and I'd rather get done with the first pre-release, so I went ahead. Just holler if you see a problem. Pushed on master + gdb-7.9-branch. Thanks, -- Joel --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/Makefile.in | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 868339c..4a903bc 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2015-01-13 Joel Brobecker + * Makefile.in (clean mostlyclean): Do not delete *.py. + +2015-01-13 Joel Brobecker + * gdb.python/py-lookup-type.exp: New file. 2015-01-12 Pedro Alves diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in index b319409..53cb754 100644 --- a/gdb/testsuite/Makefile.in +++ b/gdb/testsuite/Makefile.in @@ -242,7 +242,7 @@ force:; clean mostlyclean: -rm -f *~ core *.o a.out xgdb *.x *.grt bigcore.corefile .gdb_history - -rm -f core.* *.tf *.cl *.py tracecommandsscript copy1.txt zzz-gdbscript + -rm -f core.* *.tf *.cl tracecommandsscript copy1.txt zzz-gdbscript -rm -f *.dwo *.dwp -rm -rf outputs temp cache -rm -f read1.so expect-read1 -- 1.9.1