public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>
Subject: [PATCH] gdbserver: Fix crash when QTinit is handled with no inferior process attached
Date: Wed, 28 Jan 2015 11:37:00 -0000	[thread overview]
Message-ID: <1422387337-32334-1-git-send-email-antoine.tremblay@ericsson.com> (raw)

When gdbserver is called with --multi and attach has not been called yet
and tstart is called on the gdb client, gdbserver would crash.
This patch fixes gdbserver so that it returns E01 to the gdb client.

Also this patch adds a testcase to verify this bug named no-attach-trace.exp

gdb/ChangeLog:
	PR gdb/15956
	* gdb/gdbserver/tracepoint.c (cmd_qtinit): Added check for
	current_thread.

gdb/testsuite/ChangeLog:
	* gdb.server/no-attach-trace.c: New file.
	* gdb.server/no-attach-trace.exp: New file.
---
 gdb/gdbserver/tracepoint.c                   |    7 +++++
 gdb/testsuite/gdb.server/Makefile.in         |    2 +-
 gdb/testsuite/gdb.server/no-attach-trace.c   |   25 ++++++++++++++++
 gdb/testsuite/gdb.server/no-attach-trace.exp |   40 ++++++++++++++++++++++++++
 4 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 gdb/testsuite/gdb.server/no-attach-trace.c
 create mode 100644 gdb/testsuite/gdb.server/no-attach-trace.exp

diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index 82d6ce5..0518530 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -2377,6 +2377,13 @@ cmd_qtinit (char *packet)
 {
   struct trace_state_variable *tsv, *prev, *next;
 
+  /* Can't do this command without a pid attached */
+  if (current_thread == NULL)
+    {
+      write_enn(packet);
+      return;
+    }
+
   /* Make sure we don't try to read from a trace frame.  */
   current_traceframe = -1;
 
diff --git a/gdb/testsuite/gdb.server/Makefile.in b/gdb/testsuite/gdb.server/Makefile.in
index 509fbd8..52fe957 100644
--- a/gdb/testsuite/gdb.server/Makefile.in
+++ b/gdb/testsuite/gdb.server/Makefile.in
@@ -2,7 +2,7 @@ VPATH = @srcdir@
 srcdir = @srcdir@
 
 EXECUTABLES = ext-attach ext-run file-transfer server-mon server-run \
-	no-thread-db
+	no-thread-db no-attach-trace
 
 MISCELLANEOUS =
 
diff --git a/gdb/testsuite/gdb.server/no-attach-trace.c b/gdb/testsuite/gdb.server/no-attach-trace.c
new file mode 100644
index 0000000..383e6d0
--- /dev/null
+++ b/gdb/testsuite/gdb.server/no-attach-trace.c
@@ -0,0 +1,25 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2015 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+/* This program is intended to be a simple dummy program for gdb to read */
+
+#include <unistd.h>
+
+int main ()
+{
+  return 0;
+}
diff --git a/gdb/testsuite/gdb.server/no-attach-trace.exp b/gdb/testsuite/gdb.server/no-attach-trace.exp
new file mode 100644
index 0000000..ff75e44
--- /dev/null
+++ b/gdb/testsuite/gdb.server/no-attach-trace.exp
@@ -0,0 +1,40 @@
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2015 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test that trying to trace without a program attached fails properly.
+
+load_lib gdbserver-support.exp
+load_lib trace-support.exp
+
+standard_testfile
+
+if { [skip_gdbserver_tests] } {
+    return 0
+}
+
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
+    return -1
+}
+
+# Make sure we're disconnected, in case we're testing with an
+# extended-remote board, therefore already connected.
+gdb_test "disconnect" ".*"
+
+gdbserver_start_extended
+
+gdb_test "trace main" "Tracepoint.*"
+gdb_test "tstart" "Target returns error code '01'\."
-- 
1.7.9.5

             reply	other threads:[~2015-01-27 19:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 11:37 Antoine Tremblay [this message]
2015-02-05 13:30 ` Antoine Tremblay
2015-02-05 13:37   ` Luis Machado
2015-02-05 13:44     ` Luis Machado
2015-02-05 13:53       ` Antoine Tremblay
2015-02-05 14:04         ` Luis Machado
2015-02-05 14:06           ` Antoine Tremblay
2015-02-05 17:36             ` Pedro Alves
2015-02-05 20:06               ` [PATCH v2] " Antoine Tremblay
2015-02-06 15:50                 ` Pedro Alves
2015-02-06 16:25                   ` [PATCH v3] " Antoine Tremblay
2015-02-06 17:11                     ` Pedro Alves
2015-02-06 17:36                       ` Antoine Tremblay
2015-02-10 16:46                         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422387337-32334-1-git-send-email-antoine.tremblay@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).