From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-144861-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 50417 invoked by alias); 17 Jan 2018 12:25:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 50010 invoked by uid 89); 17 Jan 2018 12:25:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jan 2018 12:25:44 +0000
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 4F73851F03;	Wed, 17 Jan 2018 12:25:38 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 9D0B25D964;	Wed, 17 Jan 2018 12:25:37 +0000 (UTC)
Subject: Re: [PATCH 1/2] linux-nat: Remove unnecessary xstrdup
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
References: <1514732385-5506-1-git-send-email-simon.marchi@ericsson.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <14229ad8-5663-ff4a-51b1-479f75bcd3fe@redhat.com>
Date: Wed, 17 Jan 2018 12:25:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1514732385-5506-1-git-send-email-simon.marchi@ericsson.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-01/txt/msg00335.txt.bz2

On 12/31/2017 02:59 PM, Simon Marchi wrote:
> I think this xstrdup is not useful.  We can pass ex.message directly to
> throw_error instead.
> 
> gdb/ChangeLog:
> 
> 	* linux-nat.c (linux_nat_attach): Remove xstrdup.

LGTM.

Thanks,
Pedro Alves