From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15837 invoked by alias); 10 Feb 2015 20:29:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15817 invoked by uid 89); 10 Feb 2015 20:29:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 10 Feb 2015 20:29:29 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1AKTO4p009405 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Feb 2015 15:29:25 -0500 Received: from bordewijk.wildebeest.org (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1AKTNnX027516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 10 Feb 2015 15:29:24 -0500 Received: by bordewijk.wildebeest.org (Postfix, from userid 1000) id 3A0308145800; Tue, 10 Feb 2015 21:29:23 +0100 (CET) Message-ID: <1423600163.4947.86.camel@bordewijk.wildebeest.org> Subject: Re: [PATCH] Merge GCC producer parsers. Allow digits in identifiers. From: Mark Wielaard To: Joel Brobecker Cc: gdb-patches@sourceware.org Date: Tue, 10 Feb 2015 20:29:00 -0000 In-Reply-To: <1423079956.4947.52.camel@bordewijk.wildebeest.org> References: <1422185341-20243-1-git-send-email-mjw@redhat.com> <20150129080018.GH5193@adacore.com> <1422535409.4947.5.camel@bordewijk.wildebeest.org> <1423070384.4947.47.camel@bordewijk.wildebeest.org> <20150204180550.GC4738@adacore.com> <1423079956.4947.52.camel@bordewijk.wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-SW-Source: 2015-02/txt/msg00277.txt.bz2 On Wed, 2015-02-04 at 20:59 +0100, Mark Wielaard wrote: > On Wed, 2015-02-04 at 22:05 +0400, Joel Brobecker wrote: > > > How about the following cleanup: > > >=20 > > > Change producer_is_gcc function return type to bool. > > >=20 > > > gdb/ChangeLog: > > >=20 > > > * utils.h (producer_is_gcc): Change return type to bool. Add = major > > > argument. > > > * utils.c (producer_is_gcc): Likewise. > > > (producer_is_gcc_ge_4): Adjust producer_is_gcc call. > > > * dwarf2read.c (check_producer): Likewise. > >=20 > > It looks really great, thanks for doing that! > >=20 > > I have few very minor nits to report (see below), and also I'm wincing > > a bit at the use of type bool. This is the first use in GDB, and > > while I don't see that as a problem, and will pre-approve this patch, > > let's have this patch sit for a week to give people the opportunity > > to comment before we push it. >=20 > OK. I added the 3 empty lines (don't want ARI yelling at me) and will > push next week. I pushed this now. Thanks, Mark