From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [FYI 1/2] GDB: rename DYN_ATTR_DATA_LOCATION into DYN_PROP_DATA_LOCATION.
Date: Tue, 24 Mar 2015 18:28:00 -0000 [thread overview]
Message-ID: <1427221703-17826-1-git-send-email-brobecker@adacore.com> (raw)
The terminology we've been using is (dynamic) "property" rather than
"attribute", so this patch renames an enum to use the same terminology.
No behavior change.
gdb/ChangeLog:
* gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_DATA_LOCATION>:
Renames DYN_ATTR_DATA_LOCATION.
(TYPE_DATA_LOCATION): Use DYN_PROP_DATA_LOCATION instead of
DYN_ATTR_DATA_LOCATION.
* dwarf2read.c (set_die_type): Use DYN_PROP_DATA_LOCATION
instead of DYN_ATTR_DATA_LOCATION.
Tested on x86_64-linux and pushed.
Thanks,
--
Joel
---
gdb/ChangeLog | 9 +++++++++
gdb/dwarf2read.c | 2 +-
gdb/gdbtypes.h | 4 ++--
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c2a5520..78ccc8a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2015-03-24 Joel Brobecker <brobecker@adacore.com>
+
+ * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_DATA_LOCATION>:
+ Renames DYN_ATTR_DATA_LOCATION.
+ (TYPE_DATA_LOCATION): Use DYN_PROP_DATA_LOCATION instead of
+ DYN_ATTR_DATA_LOCATION.
+ * dwarf2read.c (set_die_type): Use DYN_PROP_DATA_LOCATION
+ instead of DYN_ATTR_DATA_LOCATION.
+
2015-03-24 Pedro Alves <palves@redhat.com>
* breakpoint.c (until_break_command): Adjust call to proceed.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 4946b48..96c5a33 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -22102,7 +22102,7 @@ set_die_type (struct die_info *die, struct type *type, struct dwarf2_cu *cu)
/* Read DW_AT_data_location and set in type. */
attr = dwarf2_attr (die, DW_AT_data_location, cu);
if (attr_to_dynamic_prop (attr, die, cu, &prop))
- add_dyn_prop (DYN_ATTR_DATA_LOCATION, prop, type, objfile);
+ add_dyn_prop (DYN_PROP_DATA_LOCATION, prop, type, objfile);
if (dwarf2_per_objfile->die_type_hash == NULL)
{
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 79d72df..15d6cd5 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -439,7 +439,7 @@ enum dynamic_prop_node_kind
{
/* A property providing a type's data location.
Evaluating this field yields to the location of an object's data. */
- DYN_ATTR_DATA_LOCATION,
+ DYN_PROP_DATA_LOCATION,
};
/* * List for dynamic type attributes. */
@@ -1258,7 +1258,7 @@ extern void allocate_gnat_aux_type (struct type *);
/* Property accessors for the type data location. */
#define TYPE_DATA_LOCATION(thistype) \
- get_dyn_prop (DYN_ATTR_DATA_LOCATION, thistype)
+ get_dyn_prop (DYN_PROP_DATA_LOCATION, thistype)
#define TYPE_DATA_LOCATION_BATON(thistype) \
TYPE_DATA_LOCATION (thistype)->data.baton
#define TYPE_DATA_LOCATION_ADDR(thistype) \
--
1.9.1
next reply other threads:[~2015-03-24 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 18:28 Joel Brobecker [this message]
2015-03-24 18:28 ` [FYI 2/2] Do not make "prop" field of struct dynamic_prop_list a pointer Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427221703-17826-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).