* [PATCH: gdb-7.8-branch] gdbserver: fix uClibc whithout MMU.
@ 2015-04-10 22:11 Romain Naour
2015-04-14 9:24 ` Yao Qi
0 siblings, 1 reply; 3+ messages in thread
From: Romain Naour @ 2015-04-10 22:11 UTC (permalink / raw)
To: gdb-patches; +Cc: Romain Naour
Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
must be retrieved from current_inferior.
The change has not been made in the function linux_read_offsets().
Fixes:
http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
gdb/gdbserver/linux-low.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 1a40897..71d078a 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -4933,7 +4933,7 @@ static int
linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
{
unsigned long text, text_end, data;
- int pid = lwpid_of (get_thread_lwp (current_inferior));
+ int pid = lwpid_of (current_inferior);
errno = 0;
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH: gdb-7.8-branch] gdbserver: fix uClibc whithout MMU.
2015-04-10 22:11 [PATCH: gdb-7.8-branch] gdbserver: fix uClibc whithout MMU Romain Naour
@ 2015-04-14 9:24 ` Yao Qi
2015-04-14 21:05 ` Romain Naour
0 siblings, 1 reply; 3+ messages in thread
From: Yao Qi @ 2015-04-14 9:24 UTC (permalink / raw)
To: Romain Naour; +Cc: gdb-patches
Romain Naour <romain.naour@openwide.fr> writes:
> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> index 1a40897..71d078a 100644
> --- a/gdb/gdbserver/linux-low.c
> +++ b/gdb/gdbserver/linux-low.c
> @@ -4933,7 +4933,7 @@ static int
> linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
> {
> unsigned long text, text_end, data;
> - int pid = lwpid_of (get_thread_lwp (current_inferior));
> + int pid = lwpid_of (current_inferior);
The patch is OK to the mainline, with a ChangeLog entry. I don't know
we'll have releases on 7.8 branch.
Can you commit your patch to git mainline? or you want me to commit it
for you.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH: gdb-7.8-branch] gdbserver: fix uClibc whithout MMU.
2015-04-14 9:24 ` Yao Qi
@ 2015-04-14 21:05 ` Romain Naour
0 siblings, 0 replies; 3+ messages in thread
From: Romain Naour @ 2015-04-14 21:05 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
Hi,
Le 14/04/2015 11:24, Yao Qi a écrit :
> Romain Naour <romain.naour@openwide.fr> writes:
>
>> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
>> index 1a40897..71d078a 100644
>> --- a/gdb/gdbserver/linux-low.c
>> +++ b/gdb/gdbserver/linux-low.c
>> @@ -4933,7 +4933,7 @@ static int
>> linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
>> {
>> unsigned long text, text_end, data;
>> - int pid = lwpid_of (get_thread_lwp (current_inferior));
>> + int pid = lwpid_of (current_inferior);
>
> The patch is OK to the mainline, with a ChangeLog entry. I don't know
> we'll have releases on 7.8 branch.
Thanks for your review, I'll send an updated patch rebased on master.
If you are interested, take a look at gdb's build 7.8.2 result:
http://autobuild.buildroot.net/?reason=gdb-7.8.2
gdb 7.9 is not yet tested by autobuilders.
>
> Can you commit your patch to git mainline? or you want me to commit it
> for you.
>
Yes please, I don't have git access to commit my patch.
Best regards,
Romain Naour
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-14 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-10 22:11 [PATCH: gdb-7.8-branch] gdbserver: fix uClibc whithout MMU Romain Naour
2015-04-14 9:24 ` Yao Qi
2015-04-14 21:05 ` Romain Naour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).