From: Patrick Palka <patrick@parcs.ath.cx>
To: gdb-patches@sourceware.org
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: [PATCH 3/3] Disable readline's SIGWINCH handler
Date: Fri, 24 Apr 2015 00:54:00 -0000 [thread overview]
Message-ID: <1429836801-14218-3-git-send-email-patrick@parcs.ath.cx> (raw)
In-Reply-To: <1429836801-14218-1-git-send-email-patrick@parcs.ath.cx>
We no longer need it as we handle SIGWINCH ourselves. Also move the
call to init_page_info() from initialize_utils() to the latter
function's only caller, gdb_init().
gdb/ChangeLog:
* utils.c (init_page_info): Set rl_catch_sigwinch to zero.
(initialize_utils): Move call of init_page_info() to ...
* top.c (gdb_init): ... here.
---
gdb/top.c | 2 ++
gdb/utils.c | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/gdb/top.c b/gdb/top.c
index 647d9fb..ddf5415 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1939,6 +1939,8 @@ gdb_init (char *argv0)
initialize_targets (); /* Setup target_terminal macros for utils.c. */
initialize_utils (); /* Make errors and warnings possible. */
+ init_page_info ();
+
/* Here is where we call all the _initialize_foo routines. */
initialize_all_files ();
diff --git a/gdb/utils.c b/gdb/utils.c
index ec2fd87..b4d8680 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1696,6 +1696,9 @@ init_page_info (void)
#endif
}
+ /* We handle SIGWINCH ourselves. */
+ rl_catch_sigwinch = 0;
+
set_screen_size ();
set_width ();
}
@@ -2712,8 +2715,6 @@ Setting this to \"unlimited\" or zero causes GDB never pause during output."),
show_lines_per_page,
&setlist, &showlist);
- init_page_info ();
-
add_setshow_boolean_cmd ("pagination", class_support,
&pagination_enabled, _("\
Set state of GDB output pagination."), _("\
--
2.4.0.rc2.31.g7c597ef
next prev parent reply other threads:[~2015-04-24 0:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 0:53 [PATCH 1/3] Introduce function for directly updating GDB's screen dimensions Patrick Palka
2015-04-24 0:54 ` Patrick Palka [this message]
2015-04-27 16:35 ` [PATCH 3/3] Disable readline's SIGWINCH handler Pedro Alves
2015-04-24 0:54 ` [PATCH 2/3] Update our idea of our terminal's dimensions even outside of TUI Patrick Palka
2015-04-24 16:49 ` Joel Brobecker
2015-04-27 16:35 ` Pedro Alves
2015-04-28 9:17 ` Patrick Palka
2015-04-28 13:15 ` Pedro Alves
2015-04-28 12:31 ` [PATCH 1/3] Introduce function for directly updating GDB's screen dimensions Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429836801-14218-3-git-send-email-patrick@parcs.ath.cx \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).