Re: [PATCH 0/6] Use PTRACE_GETREGSET and PTRACE_SETREGSET in arm-linux-nat.c

[Mark Wielaard <mjw@redhat.com>]

Hi Yao,

On Mon, 2015-06-01 at 12:17 +0100, Yao Qi wrote:
> On 28/05/15 15:20, Yao Qi wrote:
> > This patch series is to let GDB arm-linux-nat.c use ptrace commands
> > PTRACE_GETREGSET and PTRACE_SETREGSET if linux kernel supports.
> >
> > Patch #1 and #2 are factoring out macros and variables into more
> > common files.  Patch #3 checks whether PTRACE_GETREGSET is supported by
> > linux kernel.  Patch #4 - #6 use PTRACE_{G,S}ETREGSET ptrace commands
> > to fetch and store general purpose registers, FP registers and VFP
> > registers.
> >
> > The whole test series are tested on x86_64-linux and arm-linux (with
> > PTRACE_GETREGSET and without PTRACE_GETREGSET kernel support respectively).
> >
> > After these patches, arm-linux-nat.c is similar to aarch64-linux-nat.c
> > in the aspect of fetching and storing registers.  It paves the way for
> > multi-arch support in aarch64 gdb (aarch64 gdb can do native debugging
> > for arm program), which is the motivation of this patch series.
> 
> I removed " == 1" from the condition, as suggested by Doug, and pushed
> these patches in.

I believe this caused a build regression on i386. After this patch
series went in various buildbot i386 buildslaves builds started failing:
http://gdb-build.sergiodj.net/waterfall

../../binutils-gdb/gdb/i386-linux-nat.c: In function ‘fetch_xstateregs’:
../../binutils-gdb/gdb/i386-linux-nat.c:329:8: error: ‘have_ptrace_getregset’ undeclared (first use in this function)
../../binutils-gdb/gdb/i386-linux-nat.c:329:8: note: each undeclared identifier is reported only once for each function it appears in
../../binutils-gdb/gdb/i386-linux-nat.c: In function ‘store_xstateregs’:
../../binutils-gdb/gdb/i386-linux-nat.c:352:8: error: ‘have_ptrace_getregset’ undeclared (first use in this function)
make[2]: *** [i386-linux-nat.o] Error 1

Could you take a look?

Thanks,

Mark