From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 1A65F3858D28 for ; Mon, 1 May 2023 15:13:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A65F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F3C602245C; Mon, 1 May 2023 15:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682954008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zORjzmvbD7ETs6NlF0xDfbQg0qzU1lCEwNs1CEWQLgI=; b=xfMsrH5UcGfA0rasa+cGby8sDxh/b1Ecg5LQPTaC6FWJWlImD91SKCWW2ZQ/fB7WjRqkJu AXlFSpOcuoV4bXaXGd2fNJCQsEwzkKWZYalKQmaqGPQI0m+IrCE5MpoYKRvE5tjeBYly4I wWShPu2mvAsvNleIcchQu8OXn9D/Ab0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682954008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zORjzmvbD7ETs6NlF0xDfbQg0qzU1lCEwNs1CEWQLgI=; b=VkhGuOpcZ2DmR8aEf/GiPbTYINLHaAzQ8vdeKOQvj9CFDWOKun+e5GRH4ZGFEu1FFRJ2Yu pSDFW00YhsNhPdBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DDF7113587; Mon, 1 May 2023 15:13:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z6DWNBfXT2TJGgAAMHmgww (envelope-from ); Mon, 01 May 2023 15:13:27 +0000 Message-ID: <14333280-6e66-0cc5-7e34-46176588ee37@suse.de> Date: Mon, 1 May 2023 17:10:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 4/5] gdb/testsuite: change newline patterns used in gdb_test Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <464e64e3a3483c228f0a73c778bcaf79e4595abd.1680293848.git.aburgess@redhat.com> <7552d3ad-c148-f0ea-b219-dd2d9458de0c@suse.de> <871qk09l5j.fsf@redhat.com> From: Tom de Vries In-Reply-To: <871qk09l5j.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/1/23 16:33, Andrew Burgess wrote: > Tom de Vries writes: > >> On 3/31/23 22:20, Andrew Burgess via Gdb-patches wrote: >>> This commit makes two changes to how we match newline characters in >>> the gdb_test proc. >> >> Hi, >> >> the -wrap used in gdb_test_multiple is defined in terms of gdb_test >> semantics, but it doesn't seem to have been updated to match the new >> behaviour in gdb_test. >> >> I've filed a PR about this regression ( >> https://sourceware.org/bugzilla/show_bug.cgi?id=30403 ). > > Sorry for any problems caused. I'm not working today, but if this has > not been addressed, I'll look at this on Tuesday. AFAIU it's a silent regression, so there are no problems in term of FAILs, it's just that more work is required. FWIW, I think the root cause for introducing this regression silently is that we try to implement the same thing in two different locations, and it's just easy for things to get out of sync. I recently fixed something similar in commit 4fa173cfd79 ("[gdb/testsuite] Fix -wrap in presence of -prompt in gdb_test_multiple"), that's why I noticed it. Thanks, - Tom