From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/4] sim: trace: use existing defines for the useful mask
Date: Thu, 11 Jun 2015 15:58:00 -0000 [thread overview]
Message-ID: <1434038294-32159-2-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1434038294-32159-1-git-send-email-vapier@gentoo.org>
No point in duplicating the shift logic when we have macros already to
keep that all unified.
Committed.
---
sim/common/ChangeLog | 4 ++++
sim/common/sim-trace.h | 5 +----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index 039c675..586f58d 100644
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,5 +1,9 @@
2015-06-11 Mike Frysinger <vapier@gentoo.org>
+ * sim-trace.h (TRACE_USEFUL_MASK): Change to TRACE_xxx defines.
+
+2015-06-11 Mike Frysinger <vapier@gentoo.org>
+
* sim-trace.h (WITH_TRACE_P): New define.
(WITH_TRACE_INSN_P, WITH_TRACE_DECODE_P, WITH_TRACE_EXTRACT_P,
WITH_TRACE_LINENUM_P, WITH_TRACE_MEMORY_P, WITH_TRACE_MODEL_P,
diff --git a/sim/common/sim-trace.h b/sim/common/sim-trace.h
index df995a6..3d91aa9 100644
--- a/sim/common/sim-trace.h
+++ b/sim/common/sim-trace.h
@@ -87,10 +87,7 @@ enum {
splat on the screen everything under the sun making nothing easy to
find. */
#define TRACE_USEFUL_MASK \
-((1 << TRACE_INSN_IDX) \
- | (1 << TRACE_LINENUM_IDX) \
- | (1 << TRACE_MEMORY_IDX) \
- | (1 << TRACE_MODEL_IDX))
+ (TRACE_insn | TRACE_linenum | TRACE_memory | TRACE_model)
\f
/* Masks so WITH_TRACE can have symbolic values.
The case choice here is on purpose. The lowercase parts are args to
--
2.4.1
next prev parent reply other threads:[~2015-06-11 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 15:58 [PATCH 1/4] sim: trace: create a common WITH_TRACE_P macro Mike Frysinger
2015-06-11 15:58 ` Mike Frysinger [this message]
2015-06-11 15:58 ` [PATCH 4/4] sim: trace: centralize the system tracing Mike Frysinger
2015-06-11 15:58 ` [PATCH 3/4] sim: trace: add STRACE_xxx_P macros Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434038294-32159-2-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).