public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] sim: syscall: simplify unknown syscall trace
Date: Thu, 18 Jun 2015 08:08:00 -0000	[thread overview]
Message-ID: <1434614902-6109-1-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1434561630-16170-3-git-send-email-vapier@gentoo.org>

Since we always include the raw syscall number when tracing, also
including it in the name when it's unknown is redundant.  Simplify
the code by using a constant string.

Committed.
---
 sim/common/ChangeLog     | 5 +++++
 sim/common/sim-syscall.c | 7 ++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index afc1b3a..ecbaad1 100644
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,5 +1,10 @@
 2015-06-18  Mike Frysinger  <vapier@gentoo.org>
 
+	* sim-syscall.c (sim_syscall_multi): Change unknown_syscall to a
+	constant string.
+
+2015-06-18  Mike Frysinger  <vapier@gentoo.org>
+
 	* callback.c (cb_target_map_entry, cb_host_map_entry): Change map to
 	m for sentinel testing.
 
diff --git a/sim/common/sim-syscall.c b/sim/common/sim-syscall.c
index 6f4c8a3..ff5e5d2 100644
--- a/sim/common/sim-syscall.c
+++ b/sim/common/sim-syscall.c
@@ -60,7 +60,7 @@ sim_syscall_multi (SIM_CPU *cpu, int func, long arg1, long arg2, long arg3,
   SIM_DESC sd = CPU_STATE (cpu);
   host_callback *cb = STATE_CALLBACK (sd);
   CB_SYSCALL sc;
-  char unknown_syscall[30];
+  const char unknown_syscall[] = "<UNKNOWN SYSCALL>";
   const char *syscall;
 
   CB_SYSCALL_INIT (&sc);
@@ -85,10 +85,7 @@ sim_syscall_multi (SIM_CPU *cpu, int func, long arg1, long arg2, long arg3,
 
   syscall = cb_target_str_syscall (cb, func);
   if (!syscall)
-    {
-      sprintf (unknown_syscall, "syscall_%i", func);
-      syscall = unknown_syscall;
-    }
+    syscall = unknown_syscall;
 
   if (sc.result == -1)
     TRACE_SYSCALL (cpu, "%s[%i](%#lx, %#lx, %#lx) = %li (error = %s[%i])",
-- 
2.4.1

  reply	other threads:[~2015-06-18  8:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 17:20 [PATCH 1/3] sim: callback: add human readable strings for debugging to maps Mike Frysinger
2015-06-17 17:20 ` [PATCH 2/3] sim: syscall: unify memory helpers Mike Frysinger
2015-06-17 17:20 ` [PATCH 3/3] sim: syscall: add common sim_syscall helpers Mike Frysinger
2015-06-18  8:08   ` Mike Frysinger [this message]
2015-06-18  8:04 ` [PATCH] sim: callback: fix sentinel testing when walking maps Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434614902-6109-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).