public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Patrick Palka <patrick@parcs.ath.cx>
To: gdb-patches@sourceware.org
Cc: qiyaoltc@gmail.com,	Patrick Palka <patrick@parcs.ath.cx>
Subject: [PATCH] Don't throw an error in "show mpx bound" implementation
Date: Thu, 02 Jul 2015 16:19:00 -0000	[thread overview]
Message-ID: <1435853930-32119-1-git-send-email-patrick@parcs.ath.cx> (raw)
In-Reply-To: <559559F2.90700@gmail.com>

"show" functions should not throw an exception in part because it causes
the output of the commands "info set" and "show" to get truncated.

This fixes the following fails:

    FAIL: gdb.base/default.exp: info set
    FAIL: gdb.base/default.exp: show

gdb/ChangeLog:

	* i386-tdep.c (i386_mpx_info_bounds): Don't call error, instead
	use printf_unfiltered.
	(set_mpx_cmd): Add missing trailing space to command string
	literal.
	(_initialize_i386_tdep): Give the "mpx" prefix command its
	correct name.
---
 gdb/i386-tdep.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 85e433e..371a282 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -8775,11 +8775,17 @@ i386_mpx_info_bounds (char *args, int from_tty)
   struct type *data_ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
 
   if (!i386_mpx_enabled ())
-    error (_("Intel(R) Memory Protection Extensions not\
- supported on this target."));
+    {
+      printf_unfiltered (_("Intel(R) Memory Protection Extensions not "
+			   "supported on this target.\n"));
+      return;
+    }
 
   if (args == NULL)
-    error (_("Address of pointer variable expected."));
+    {
+      printf_unfiltered (_("Address of pointer variable expected.\n"));
+      return;
+    }
 
   addr = parse_and_eval_address (args);
 
@@ -8854,7 +8860,7 @@ static struct cmd_list_element *mpx_set_cmdlist, *mpx_show_cmdlist;
 static void
 set_mpx_cmd (char *args, int from_tty)
 {
-  help_list (mpx_set_cmdlist, "set mpx", all_commands, gdb_stdout);
+  help_list (mpx_set_cmdlist, "set mpx ", all_commands, gdb_stdout);
 }
 
 /* Helper function for the CLI commands.  */
@@ -8899,7 +8905,7 @@ is \"default\"."),
 
   add_prefix_cmd ("mpx", class_support, set_mpx_cmd, _("\
 Set Intel(R) Memory Protection Extensions specific variables."),
-		  &mpx_set_cmdlist, "set tdesc ",
+		  &mpx_set_cmdlist, "set mpx ",
 		  0 /* allow-unknown */, &setlist);
 
   /* Add "mpx" prefix for the show commands.  */
-- 
2.5.0.rc0.5.g91e10c5.dirty

  reply	other threads:[~2015-07-02 16:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 18:31 Several regressions and we branch soon Doug Evans
2015-06-23 18:55 ` Patrick Palka
2015-06-23 19:03   ` Doug Evans
2015-06-23 20:17     ` Keith Seitz
2015-06-23 20:53       ` Doug Evans
2015-06-23 21:45         ` Patrick Palka
2015-06-24 11:55           ` Yao Qi
2015-06-25 16:35             ` Tedeschi, Walfred
2015-07-01  8:49               ` Yao Qi
     [not found]                 ` <AC542571535E904D8E8ADAE745D60B1944445D44@IRSMSX104.ger.corp.intel.com>
2015-07-01  9:30                   ` Walfred Tedeschi
2015-07-02 10:09                     ` Yao Qi
2015-07-02 15:34           ` Yao Qi
2015-07-02 16:19             ` Patrick Palka [this message]
2015-07-06  9:31               ` [PATCH] Don't throw an error in "show mpx bound" implementation Yao Qi
2015-06-24 10:21 ` Several regressions and we branch soon Yao Qi
2015-06-25  8:21   ` Andreas Arnez
2015-06-25 13:34     ` Doug Evans
2015-06-25 18:00       ` Andreas Arnez
2015-06-30 15:21         ` Yao Qi
2015-06-30 18:09           ` Andreas Arnez
2015-07-01  8:01             ` Yao Qi
2015-07-10  9:33             ` Yao Qi
2015-07-10 16:12               ` Andreas Arnez
2015-07-10 16:23                 ` Ulrich Weigand
2015-07-20 15:08                   ` Andreas Arnez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435853930-32119-1-git-send-email-patrick@parcs.ath.cx \
    --to=patrick@parcs.ath.cx \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).