From: Patrick Palka <patrick@parcs.ath.cx>
To: gdb-patches@sourceware.org
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: [PATCH 1/5] tui: reset start_line whenever cur_line is reset
Date: Sun, 05 Jul 2015 21:04:00 -0000 [thread overview]
Message-ID: <1436130241-21443-1-git-send-email-patrick@parcs.ath.cx> (raw)
In-Reply-To: <1436130177-21362-1-git-send-email-patrick@parcs.ath.cx>
Whenever the command window's cur_line is reset to 0, so should
start_line. This is because there is an implicit invariant that
0 <= start_line <= cur_line.
gdb/ChangeLog:
* tui/tui-data.c (tui_clear_win_detail) [CMD_WIN]: Also reset
start_line.
(init_win_info) [CMD_WIN]: Ditto.
* tui/tui-win.c (make_visible_with_new_height) [CMD_WIN]: Ditto.
---
gdb/tui/tui-data.c | 6 ++++--
gdb/tui/tui-win.c | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c
index ed42c8d..e9aa7b3 100644
--- a/gdb/tui/tui-data.c
+++ b/gdb/tui/tui-data.c
@@ -212,8 +212,9 @@ tui_clear_win_detail (struct tui_win_info *win_info)
win_info->detail.source_info.horizontal_offset = 0;
break;
case CMD_WIN:
- win_info->detail.command_info.cur_line =
- win_info->detail.command_info.curch = 0;
+ win_info->detail.command_info.start_line = 0;
+ win_info->detail.command_info.cur_line = 0;
+ win_info->detail.command_info.curch = 0;
break;
case DATA_WIN:
win_info->detail.data_display_info.data_content =
@@ -545,6 +546,7 @@ init_win_info (struct tui_win_info *win_info)
win_info->detail.data_display_info.current_group = 0;
break;
case CMD_WIN:
+ win_info->detail.command_info.start_line = 0;
win_info->detail.command_info.cur_line = 0;
win_info->detail.command_info.curch = 0;
break;
diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index feb360b..0150900 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -1510,6 +1510,7 @@ make_visible_with_new_height (struct tui_win_info *win_info)
tui_display_all_data ();
break;
case CMD_WIN:
+ win_info->detail.command_info.start_line = 0;
win_info->detail.command_info.cur_line = 0;
win_info->detail.command_info.curch = 0;
#ifdef HAVE_WRESIZE
--
2.5.0.rc0.5.g91e10c5.dirty
next prev parent reply other threads:[~2015-07-05 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 21:03 [PATCH 0/5] An attempt to provide "scrolling" functionality to TUI (PR tui/14584) Patrick Palka
2015-07-05 21:04 ` Patrick Palka [this message]
2015-07-05 21:04 ` [PATCH 3/5] tui: simplify and fix up handling of start_line in tui_redisplay_readline Patrick Palka
2015-07-05 21:04 ` [PATCH 4/5] tui: make updating of start_line in tui_puts more consistent Patrick Palka
2015-07-05 21:04 ` [PATCH 5/5] tui: maintain a scrollback buffer and dump it upon exit (PR tui/14584) Patrick Palka
2015-07-05 21:04 ` [PATCH 2/5] tui: use tui_putc to output newline entered by the user Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436130241-21443-1-git-send-email-patrick@parcs.ath.cx \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).