From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84827 invoked by alias); 14 Jul 2015 15:50:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84814 invoked by uid 89); 14 Jul 2015 15:50:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e31.co.us.ibm.com Received: from e31.co.us.ibm.com (HELO e31.co.us.ibm.com) (32.97.110.149) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 14 Jul 2015 15:50:07 +0000 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Jul 2015 09:50:05 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 14 Jul 2015 09:50:03 -0600 X-MailFrom: bergner@vnet.ibm.com X-RcptTo: gdb-patches@sourceware.org Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 6B13F19D8048 for ; Tue, 14 Jul 2015 09:41:02 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6EFo21F13041792 for ; Tue, 14 Jul 2015 08:50:02 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6EFo2dQ025421 for ; Tue, 14 Jul 2015 09:50:02 -0600 Received: from [9.77.132.14] (sig-9-77-132-14.ibm.com [9.77.132.14]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t6EFo0jv025241; Tue, 14 Jul 2015 09:50:00 -0600 Subject: Re: [PATCH] Fix build issue due to Introduce nat/linux-namespaces.[ch] patch From: Peter Bergner To: Gary Benson Cc: "gdb-patches@sourceware.org" In-Reply-To: <20150714144641.GC26999@blade.nx> References: <1436474110.5367.27.camel@otta> <20150714144641.GC26999@blade.nx> Content-Type: text/plain; charset="UTF-8" Date: Tue, 14 Jul 2015 15:50:00 -0000 Message-ID: <1436888999.5245.4.camel@otta> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071415-8236-0000-0000-00000D252E93 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00409.txt.bz2 On Tue, 2015-07-14 at 15:46 +0100, Gary Benson wrote: > I'd prefer it without the nested conditionals: > > #ifdef HAVE_SETNS > return setns (fd, nstype); > #elif defined __NR_setns > return syscall (__NR_setns, fd, nstype); > #else > errno = ENOSYS; > return -1; > #endif > > Otherwise ok. Thanks for doing this work! Hmmm, for some reason I thought #elif wasn't supported, since I agree this looks better. Maybe I was thinking of some scripting language limitation? Anyway, I committed the patch with your suggested change. Thanks! Peter