New ARI warning Sat Jul 18 01:54:21 UTC 2015

New ARI warning Sat Jul 18 01:54:21 UTC 2015

[GDB Administrator]

375a376,377
> gdb/nat/aarch64-linux-hw-point.c:417: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/nat/aarch64-linux-hw-point.c:417:core_addr_to_string_nz (addr), len);
> gdb/nat/aarch64-linux-hw-point.h:105: code: long long: Do not use 'long long', instead use LONGEST
gdb/nat/aarch64-linux-hw-point.h:105:typedef unsigned long long dr_changed_t;

[PATCH] Fix ARI warnings to nat/aarch64-linux-hw-point.{c,h}

[Yao Qi]

This patch is to fix two ARI warnings for nat/aarch64-linux-hw-point.{c,h}.
It is obvious, and I'll push it in.

gdb:

2015-07-20  Yao Qi  <yao.qi@linaro.org>

	* nat/aarch64-linux-hw-point.c (aarch64_handle_unaligned_watchpoint):
	Re-indent the code.
	* nat/aarch64-linux-hw-point.h: Use ULONGEST rather than
	"unsigned long long".
---
 gdb/nat/aarch64-linux-hw-point.c | 13 +++++++------
 gdb/nat/aarch64-linux-hw-point.h |  2 +-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/gdb/nat/aarch64-linux-hw-point.c b/gdb/nat/aarch64-linux-hw-point.c
index 09c30c0..1d9664e 100644
--- a/gdb/nat/aarch64-linux-hw-point.c
+++ b/gdb/nat/aarch64-linux-hw-point.c
@@ -409,12 +409,13 @@ aarch64_handle_unaligned_watchpoint (enum target_hw_bp_type type,
 						 aligned_len);
 
       if (show_debug_regs)
-	debug_printf (
-"handle_unaligned_watchpoint: is_insert: %d\n"
-"                             aligned_addr: %s, aligned_len: %d\n"
-"                                next_addr: %s,    next_len: %d\n",
-is_insert, core_addr_to_string_nz (aligned_addr), aligned_len,
-core_addr_to_string_nz (addr), len);
+	debug_printf ("handle_unaligned_watchpoint: is_insert: %d\n"
+		      "                             "
+		      "aligned_addr: %s, aligned_len: %d\n"
+		      "                                "
+		      "next_addr: %s,    next_len: %d\n",
+		      is_insert, core_addr_to_string_nz (aligned_addr),
+		      aligned_len, core_addr_to_string_nz (addr), len);
 
       if (ret != 0)
 	return ret;
diff --git a/gdb/nat/aarch64-linux-hw-point.h b/gdb/nat/aarch64-linux-hw-point.h
index 1d268ea..a430a8f 100644
--- a/gdb/nat/aarch64-linux-hw-point.h
+++ b/gdb/nat/aarch64-linux-hw-point.h
@@ -102,7 +102,7 @@
    ptrace calls to the kernel, i.e. avoid asking the kernel to write
    to the debug registers with unchanged values.  */
 
-typedef unsigned long long dr_changed_t;
+typedef ULONGEST dr_changed_t;
 
 /* Set each of the lower M bits of X to 1; assert X is wide enough.  */
 
-- 
1.9.1