From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24437 invoked by alias); 3 Aug 2015 16:39:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24422 invoked by uid 89); 3 Aug 2015 16:39:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Aug 2015 16:39:04 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 47BE2EF71C3D2; Mon, 3 Aug 2015 17:38:58 +0100 (IST) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 3 Aug 2015 17:39:01 +0100 Received: from [10.20.3.58] (10.20.3.58) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Mon, 3 Aug 2015 09:38:58 -0700 Message-ID: <1438619922.8302.6.camel@ubuntu-sellcey> Subject: Re: [PATCH] Replace the block_found global with explicit data-flow From: Steve Ellcey Reply-To: To: Pierre-Marie de Rodat CC: Doug Evans , GDB Patches , Pedro Alves Date: Mon, 03 Aug 2015 16:39:00 -0000 In-Reply-To: <55BC8CA9.3070505@adacore.com> References: <55BC8CA9.3070505@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SW-Source: 2015-08/txt/msg00035.txt.bz2 On Sat, 2015-08-01 at 11:08 +0200, Pierre-Marie de Rodat wrote: > On 08/01/2015 10:57 AM, Pierre-Marie de Rodat wrote: > > This is pushed, now. > > Sergio's buildbot detected a compilation error: > > ../../binutils-gdb/gdb/ft32-tdep.c: In function 'ft32_skip_prologue': > ../../binutils-gdb/gdb/ft32-tdep.c:253:8: error: incompatible types when > assigning to type 'struct symbol *' from type 'struct block_symbol' > sym = lookup_symbol (func_name, NULL, VAR_DOMAIN, NULL); > > Strange, I don't have this problem locally. Investigating how the > buildbot's build is different (mhm probably this --enable-targets=all). I am seeing a different build error that I think is due to this patch. I only see it on an old CentOS 5.11 system with GCC 4.1.2, and only when I build gdb as a 32 bit executable instead of a 64 bit executable. cc1: warnings being treated as errors /scratch/sellcey/repos/gdb-build/src/binutils-gdb/gdb/cp-namespace.c: In function 'cp_lookup_symbol_via_imports': /scratch/sellcey/repos/gdb-build/src/binutils-gdb/gdb/cp-namespace.c:482: warning: 'sym.block' may be used uninitialized in this function It looks like sym.symbol is always initialized, but sym.block is not initialized at the beginning of the function. I think it is always initialized when used but GCC (at least this version of GCC) cannot seem to figure that out. Steve Ellcey sellcey@imgtec.com