From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1124 invoked by alias); 23 Aug 2015 19:37:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1094 invoked by uid 89); 23 Aug 2015 19:36:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.4 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS,WEIRD_QUOTING autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 23 Aug 2015 19:36:58 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 7F69E461DC; Sun, 23 Aug 2015 19:36:57 +0000 (UTC) Received: from YAAKOV04.redhat.com (ovpn-116-27.rdu2.redhat.com [10.10.116.27]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7NJatSI030080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 23 Aug 2015 15:36:56 -0400 Message-ID: <1440358616.9072.5.camel@redhat.com> Subject: Re: [PATCH] config: fix AM_ICONV for in-tree libiconv From: Yaakov Selkowitz To: gcc-patches@gcc.gnu.org, "binutils@sourceware.org" , "gdb-patches@sourceware.org" Cc: DJ Delorie Date: Sun, 23 Aug 2015 19:37:00 -0000 In-Reply-To: <55D8ABBA.3090208@redhat.com> References: <1432934749.13692.9.camel@redhat.com> <55D8ABBA.3090208@redhat.com> Content-Type: multipart/mixed; boundary="=-sCrL1xJj4HTBY3OnNgGy" Mime-Version: 1.0 X-SW-Source: 2015-08/txt/msg00661.txt.bz2 --=-sCrL1xJj4HTBY3OnNgGy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 535 On Sat, 2015-08-22 at 18:04 +0100, Pedro Alves wrote: > I noticed that regenerating binutils/configure or gdb/configure > undoes the libiconv changes done here: [snip] > However, that commit does not include any config/iconv.m4/AM_ICONV > change. Looks like you forgot to attach the config/iconv.m4 patch, and > then only the regeneration bits were pushed (both binutils-gdb git > and gcc svn)? Looks like I forgot to repost that part of the patchset; attached. -- Yaakov Selkowitz Associate Software Engineer, ARM Red Hat, Inc. --=-sCrL1xJj4HTBY3OnNgGy Content-Disposition: attachment; filename="0002-config-libiconv.patch" Content-Type: text/x-patch; name="0002-config-libiconv.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 Content-length: 4681 MjAxNS0wNy0wMSAgWWFha292IFNlbGtvd2l0eiAgPHlzZWxrb3dpQHJlZGhh dC5jb20+CgoJY29uZmlnLwoJKiBpY29udi5tNCAoQU1fSUNPTlZfTElOSyk6 IFVzZSBpbi10cmVlIGxpYmljb252IHdoZW4gcHJlc2VudC4KCkluZGV4OiBj b25maWcvaWNvbnYubTQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY29u ZmlnL2ljb252Lm00CShyZXZpc2lvbiAyMjM4NzUpCisrKyBjb25maWcvaWNv bnYubTQJKHdvcmtpbmcgY29weSkKQEAgLTcsNiArNyw3IEBACiBkbmwgdGhl IHNhbWUgZGlzdHJpYnV0aW9uIHRlcm1zIGFzIHRoZSByZXN0IG9mIHRoYXQg cHJvZ3JhbS4KIAogZG5sIEZyb20gQnJ1bm8gSGFpYmxlLgorZG5sIHdpdGgg bW9kaWZpY2F0aW9ucyB0byBzdXBwb3J0IGJ1aWxkaW5nIHdpdGggaW4tdHJl ZSBsaWJpY29udgogCiBBQ19ERUZVTihbQU1fSUNPTlZfTElOS0ZMQUdTX0JP RFldLAogWwpAQCAtMjgsMTYgKzI5LDE1IEBACiAgIGRubCBhY2NvcmRpbmds eS4KICAgQUNfUkVRVUlSRShbQU1fSUNPTlZfTElOS0ZMQUdTX0JPRFldKQog Ci0gIGRubCBBZGQgJElOQ0lDT05WIHRvIENQUEZMQUdTIGJlZm9yZSBwZXJm b3JtaW5nIHRoZSBmb2xsb3dpbmcgY2hlY2tzLAotICBkbmwgYmVjYXVzZSBp ZiB0aGUgdXNlciBoYXMgaW5zdGFsbGVkIGxpYmljb252IGFuZCBub3QgZGlz YWJsZWQgaXRzIHVzZQotICBkbmwgdmlhIC0td2l0aG91dC1saWJpY29udi1w cmVmaXgsIGhlIHdhbnRzIHRvIHVzZSBpdC4gVGhlIGZpcnN0Ci0gIGRubCBB Q19UUllfTElOSyB3aWxsIHRoZW4gZmFpbCwgdGhlIHNlY29uZCBBQ19UUllf TElOSyB3aWxsIHN1Y2NlZWQuCi0gIGFtX3NhdmVfQ1BQRkxBR1M9IiRDUFBG TEFHUyIKLSAgQUNfTElCX0FQUEVORFRPVkFSKFtDUFBGTEFHU10sIFskSU5D SUNPTlZdKQotCiAgIEFDX0NBQ0hFX0NIRUNLKGZvciBpY29udiwgYW1fY3Zf ZnVuY19pY29udiwgWwogICAgIGFtX2N2X2Z1bmNfaWNvbnY9Im5vLCBjb25z aWRlciBpbnN0YWxsaW5nIEdOVSBsaWJpY29udiIKICAgICBhbV9jdl9saWJf aWNvbnY9bm8KKyAgICBkbmwgQWRkICRJTkNJQ09OViB0byBDUFBGTEFHUyBi ZWZvcmUgcGVyZm9ybWluZyB0aGUgZmlyc3QgY2hlY2ssCisgICAgZG5sIGJl Y2F1c2UgaWYgdGhlIHVzZXIgaGFzIGluc3RhbGxlZCBsaWJpY29udiBhbmQg bm90IGRpc2FibGVkIGl0cyB1c2UKKyAgICBkbmwgdmlhIC0td2l0aG91dC1s aWJpY29udi1wcmVmaXgsIGhlIHdhbnRzIHRvIHVzZSBpdC4gVGhpcyBmaXJz dAorICAgIGRubCBBQ19UUllfTElOSyB3aWxsIHRoZW4gZmFpbCwgdGhlIHNl Y29uZCBBQ19UUllfTElOSyB3aWxsIHN1Y2NlZWQuCisgICAgYW1fc2F2ZV9D UFBGTEFHUz0iJENQUEZMQUdTIgorICAgIENQUEZMQUdTPSIkQ1BQRkxBR1Mg JElOQ0lDT05WIgogICAgIEFDX1RSWV9MSU5LKFsjaW5jbHVkZSA8c3RkbGli Lmg+CiAjaW5jbHVkZSA8aWNvbnYuaD5dLAogICAgICAgW2ljb252X3QgY2Qg PSBpY29udl9vcGVuKCIiLCIiKTsKQEAgLTQ0LDggKzQ0LDM2IEBACiAgICAg ICAgaWNvbnYoY2QsTlVMTCxOVUxMLE5VTEwsTlVMTCk7CiAgICAgICAgaWNv bnZfY2xvc2UoY2QpO10sCiAgICAgICBhbV9jdl9mdW5jX2ljb252PXllcykK KyAgICBDUFBGTEFHUz0iJGFtX3NhdmVfQ1BQRkxBR1MiCisKKyAgICBpZiB0 ZXN0ICIkYW1fY3ZfZnVuY19pY29udiIgIT0geWVzICYmIHRlc3QgLWQgLi4v bGliaWNvbnY7IHRoZW4KKyAgICAgIGZvciBfbGlicyBpbiAubGlicyBfbGli czsgZG8KKyAgICAgICAgYW1fc2F2ZV9DUFBGTEFHUz0iJENQUEZMQUdTIgor ICAgICAgICBhbV9zYXZlX0xJQlM9IiRMSUJTIgorICAgICAgICBDUFBGTEFH Uz0iJENQUEZMQUdTIC1JLi4vbGliaWNvbnYvaW5jbHVkZSIKKyAgICAgICAg TElCUz0iJExJQlMgLi4vbGliaWNvbnYvbGliLyRfbGlicy9saWJpY29udi5h IgorICAgICAgICBBQ19UUllfTElOSyhbI2luY2x1ZGUgPHN0ZGxpYi5oPgor I2luY2x1ZGUgPGljb252Lmg+XSwKKyAgICAgICAgICBbaWNvbnZfdCBjZCA9 IGljb252X29wZW4oIiIsIiIpOworICAgICAgICAgICBpY29udihjZCxOVUxM LE5VTEwsTlVMTCxOVUxMKTsKKyAgICAgICAgICAgaWNvbnZfY2xvc2UoY2Qp O10sCisgICAgICAgICAgSU5DSUNPTlY9Ii1JLi4vbGliaWNvbnYvaW5jbHVk ZSIKKyAgICAgICAgICBMSUJJQ09OVj0nJHt0b3BfYnVpbGRkaXJ9Jy8uLi9s aWJpY29udi9saWIvJF9saWJzL2xpYmljb252LmEKKyAgICAgICAgICBMVExJ QklDT05WPScke3RvcF9idWlsZGRpcn0nLy4uL2xpYmljb252L2xpYi9saWJp Y29udi5sYQorICAgICAgICAgIGFtX2N2X2xpYl9pY29udj15ZXMKKyAgICAg ICAgICBhbV9jdl9mdW5jX2ljb252PXllcykKKyAgICAgICAgQ1BQRkxBR1M9 IiRhbV9zYXZlX0NQUEZMQUdTIgorICAgICAgICBMSUJTPSIkYW1fc2F2ZV9M SUJTIgorICAgICAgICBpZiB0ZXN0ICIkYW1fY3ZfZnVuY19pY29udiIgPSAi eWVzIjsgdGhlbgorICAgICAgICAgIGJyZWFrCisgICAgICAgIGZpCisgICAg ICBkb25lCisgICAgZmkKKwogICAgIGlmIHRlc3QgIiRhbV9jdl9mdW5jX2lj b252IiAhPSB5ZXM7IHRoZW4KKyAgICAgIGFtX3NhdmVfQ1BQRkxBR1M9IiRD UFBGTEFHUyIKICAgICAgIGFtX3NhdmVfTElCUz0iJExJQlMiCisgICAgICBD UFBGTEFHUz0iJExJQlMgJElOQ0lDT05WIgogICAgICAgTElCUz0iJExJQlMg JExJQklDT05WIgogICAgICAgQUNfVFJZX0xJTksoWyNpbmNsdWRlIDxzdGRs aWIuaD4KICNpbmNsdWRlIDxpY29udi5oPl0sCkBAIC01NCw2ICs4Miw3IEBA CiAgICAgICAgICBpY29udl9jbG9zZShjZCk7XSwKICAgICAgICAgYW1fY3Zf bGliX2ljb252PXllcwogICAgICAgICBhbV9jdl9mdW5jX2ljb252PXllcykK KyAgICAgIENQUEZMQUdTPSIkYW1fc2F2ZV9DUFBGTEFHUyIKICAgICAgIExJ QlM9IiRhbV9zYXZlX0xJQlMiCiAgICAgZmkKICAgXSkKQEAgLTYxLDEyICs5 MCwxMCBAQAogICAgIEFDX0RFRklORShIQVZFX0lDT05WLCAxLCBbRGVmaW5l IGlmIHlvdSBoYXZlIHRoZSBpY29udigpIGZ1bmN0aW9uLl0pCiAgIGZpCiAg IGlmIHRlc3QgIiRhbV9jdl9saWJfaWNvbnYiID0geWVzOyB0aGVuCisgICAg QUNfTElCX0FQUEVORFRPVkFSKFtDUFBGTEFHU10sIFskSU5DSUNPTlZdKQog ICAgIEFDX01TR19DSEVDS0lORyhbaG93IHRvIGxpbmsgd2l0aCBsaWJpY29u dl0pCiAgICAgQUNfTVNHX1JFU1VMVChbJExJQklDT05WXSkKICAgZWxzZQot ICAgIGRubCBJZiAkTElCSUNPTlYgZGlkbid0IGxlYWQgdG8gYSB1c2FibGUg bGlicmFyeSwgd2UgZG9uJ3QgbmVlZCAkSU5DSUNPTlYKLSAgICBkbmwgZWl0 aGVyLgotICAgIENQUEZMQUdTPSIkYW1fc2F2ZV9DUFBGTEFHUyIKICAgICBM SUJJQ09OVj0KICAgICBMVExJQklDT05WPQogICBmaQo= --=-sCrL1xJj4HTBY3OnNgGy--