public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH obv/pushed] Fix inverted statements in m88k_analyze_prologue
@ 2015-08-27 13:49 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2015-08-27 13:49 UTC (permalink / raw)
  To: gdb-patches; +Cc: Simon Marchi

These two statements were inverted by mistake in commit "Replace some
xmalloc-family functions with XNEW-family ones".  It obviously doesn't
make sense to have them in this order, which is why I am pushing this as
obvious.

gdb/ChangeLog:

	* m88k-tdep.c (m88k_analyze_prologue): Fix inverted allocation
	statements.
---
 gdb/ChangeLog   | 5 +++++
 gdb/m88k-tdep.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b2d6c91..b572271 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2015-08-27  Simon Marchi  <simon.marchi@ericsson.com>
 
+	* m88k-tdep.c (m88k_analyze_prologue): Fix inverted allocation
+	statements.
+
+2015-08-27  Simon Marchi  <simon.marchi@ericsson.com>
+
 	* NEWS: Document support for non-8-bits addressable memory.
 
 2015-08-27  Pedro Alves  <palves@redhat.com>
diff --git a/gdb/m88k-tdep.c b/gdb/m88k-tdep.c
index 47a8f57..abfd082 100644
--- a/gdb/m88k-tdep.c
+++ b/gdb/m88k-tdep.c
@@ -533,9 +533,9 @@ m88k_analyze_prologue (struct gdbarch *gdbarch,
   /* Provide a dummy cache if necessary.  */
   if (cache == NULL)
     {
-      cache->saved_regs
-	= XALLOCAVEC (struct trad_frame_saved_reg, M88K_R31_REGNUM + 1);
       cache = XALLOCA (struct m88k_frame_cache);
+      cache->saved_regs =
+        XALLOCAVEC (struct trad_frame_saved_reg, M88K_R31_REGNUM + 1);
 
       /* We only initialize the members we care about.  */
       cache->saved_regs[M88K_R1_REGNUM].addr = -1;
-- 
2.1.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-27 13:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-27 13:49 [PATCH obv/pushed] Fix inverted statements in m88k_analyze_prologue Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).