From: Patrick Palka <patrick@parcs.ath.cx>
To: gdb-patches@sourceware.org
Cc: xdje42@gmail.com, Patrick Palka <patrick@parcs.ath.cx>
Subject: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type
Date: Sat, 29 Aug 2015 22:33:00 -0000 [thread overview]
Message-ID: <1440887600-22980-1-git-send-email-patrick@parcs.ath.cx> (raw)
In-Reply-To: <CA+C-WL9MJMGm8xEJMeHzWC-A=s2qPAty76S2q3FgRf=pnfi7KA@mail.gmail.com>
[ The earlier committed version of this patch was reverted. ]
Since the type whose name is being set is now being allocated on the
gdbarch obstack, we should allocate its TYPE_NAME on the obstack too.
This reduces the number of individual valgrind warnings for the command
"gdb gdb" from ~300 to ~150.
Tested on x86_64-unknown-linux-gnu.
gdb/ChangeLog:
* gdb_obstack.h (obstack_strdup): Declare.
* gdb_obstack.c (obstack_strdup): Declare.
* gdbarch.sh (gdbarch_obstack_strdup): Declare and define.
* gdbarch.c: Regenerate.
* gdbarch.h: Regenerate.
* gdbtypes.c (arch_type): Use gdbarch_obstack_strdup.
---
gdb/gdb_obstack.c | 10 ++++++++++
gdb/gdb_obstack.h | 5 +++++
gdb/gdbarch.c | 8 ++++++++
gdb/gdbarch.h | 5 +++++
gdb/gdbarch.sh | 13 +++++++++++++
gdb/gdbtypes.c | 2 +-
6 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/gdb/gdb_obstack.c b/gdb/gdb_obstack.c
index b972eab..d8d03df 100644
--- a/gdb/gdb_obstack.c
+++ b/gdb/gdb_obstack.c
@@ -45,3 +45,13 @@ obconcat (struct obstack *obstackp, ...)
return obstack_finish (obstackp);
}
+
+/* See gdb_obstack.h. */
+
+char *
+obstack_strdup (struct obstack *obstackp, const char *string)
+{
+ char *obstring = obstack_alloc (obstackp, strlen (string) + 1);
+ strcpy (obstring, string);
+ return obstring;
+}
diff --git a/gdb/gdb_obstack.h b/gdb/gdb_obstack.h
index 826c8b2..3272721 100644
--- a/gdb/gdb_obstack.h
+++ b/gdb/gdb_obstack.h
@@ -58,4 +58,9 @@
extern char *obconcat (struct obstack *obstackp, ...) ATTRIBUTE_SENTINEL;
+/* Duplicate STRING, returning an equivalent string that's allocated on the
+ obstack OBSTACKP. */
+
+extern char *obstack_strdup (struct obstack *obstackp, const char *string);
+
#endif
diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c
index 0d4142b..f04eef9 100644
--- a/gdb/gdbarch.c
+++ b/gdb/gdbarch.c
@@ -449,6 +449,14 @@ gdbarch_obstack_zalloc (struct gdbarch *arch, long size)
return data;
}
+/* See gdbarch.h. */
+
+char *
+gdbarch_obstack_strdup (struct gdbarch *arch, const char *string)
+{
+ return obstack_strdup (arch->obstack, string);
+}
+
/* Free a gdbarch struct. This should never happen in normal
operation --- once you've created a gdbarch, you keep it around.
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 7df37c9..82e0259 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -1618,6 +1618,11 @@ extern void *gdbarch_obstack_zalloc (struct gdbarch *gdbarch, long size);
#define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE)))
#define GDBARCH_OBSTACK_ZALLOC(GDBARCH, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), sizeof (TYPE)))
+/* Duplicate STRING, returning an equivalent string that's allocated on the
+ obstack associated with GDBARCH. The string is freed when the corresponding
+ architecture is also freed. */
+
+extern char *gdbarch_obstack_strdup (struct gdbarch *arch, const char *string);
/* Helper function. Force an update of the current architecture.
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 34e6a74..388920f 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -1486,6 +1486,11 @@ extern void *gdbarch_obstack_zalloc (struct gdbarch *gdbarch, long size);
#define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE)))
#define GDBARCH_OBSTACK_ZALLOC(GDBARCH, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), sizeof (TYPE)))
+/* Duplicate STRING, returning an equivalent string that's allocated on the
+ obstack associated with GDBARCH. The string is freed when the corresponding
+ architecture is also freed. */
+
+extern char *gdbarch_obstack_strdup (struct gdbarch *arch, const char *string);
/* Helper function. Force an update of the current architecture.
@@ -1791,6 +1796,14 @@ gdbarch_obstack_zalloc (struct gdbarch *arch, long size)
return data;
}
+/* See gdbarch.h. */
+
+char *
+gdbarch_obstack_strdup (struct gdbarch *arch, const char *string)
+{
+ return obstack_strdup (arch->obstack, string);
+}
+
/* Free a gdbarch struct. This should never happen in normal
operation --- once you've created a gdbarch, you keep it around.
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 7a18bed..12ff014 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -4549,7 +4549,7 @@ arch_type (struct gdbarch *gdbarch,
TYPE_LENGTH (type) = length;
if (name)
- TYPE_NAME (type) = xstrdup (name);
+ TYPE_NAME (type) = gdbarch_obstack_strdup (gdbarch, name);
return type;
}
--
2.5.1.426.g4b27743.dirty
next prev parent reply other threads:[~2015-08-29 22:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 2:28 [PATCH 1/2] Use gdbarch obstack to allocate types in alloc_type_arch Patrick Palka
2015-06-30 2:28 ` [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type Patrick Palka
2015-06-30 9:36 ` Pedro Alves
2015-06-30 20:05 ` Patrick Palka
2015-08-29 12:59 ` Patrick Palka
2015-08-29 18:20 ` Doug Evans
2015-08-29 21:29 ` Patrick Palka
2015-08-29 22:33 ` Patrick Palka [this message]
2015-09-02 5:12 ` Doug Evans
2015-08-29 18:06 ` [PATCH 1/2] Use gdbarch obstack to allocate types in alloc_type_arch Doug Evans
2015-08-29 21:26 ` Patrick Palka
2015-08-29 21:35 ` Doug Evans
2015-08-29 22:30 ` Patrick Palka
2015-08-29 22:31 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440887600-22980-1-git-send-email-patrick@parcs.ath.cx \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).