From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8723 invoked by alias); 25 Nov 2016 18:20:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8709 invoked by uid 89); 25 Nov 2016 18:20:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-Greylist:succeeded, HX-Greylist:SMTP, HX-Greylist:AUTH, HX-Greylist:EST X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 18:20:44 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 5C53910A982; Fri, 25 Nov 2016 13:20:41 -0500 (EST) From: John Baldwin To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Define an error function in the PPC simulator. Date: Fri, 25 Nov 2016 18:20:00 -0000 Message-ID: <14422610.OhF153fWFS@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: <20161125164908.GI21655@vapier.lan> References: <20161124152917.52189-1-jhb@FreeBSD.org> <20161125164908.GI21655@vapier.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00831.txt.bz2 On Friday, November 25, 2016 08:49:08 AM Mike Frysinger wrote: > On 24 Nov 2016 07:29, John Baldwin wrote: > > Previously this used the error function from GDB directly instead of > > the error method in the host callbacks structure. This was exposed via > > a link error when GDB was converted to C++. The error function invokes > > the error callback similar to sim_io_error. > > ppc/main.c and ppc/misc.c already have error() definitions Yes, though those are not included when libsim is linked into gdb itself. misc.o is explicitly included for certain binaries in sim/ppc/Makefile.in. Note that zalloc() is defined in both misc.c and sim_calls.c as well, I suspect for similar reasons. Looking at main.c, it overrides various symbols (sim_io_*, also zalloc) that are defined in sim_calls.c with local versions. (Perhaps psim should not be linking sim_calls.o in at all?) 'error' is another such symbol. -- John Baldwin