public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] sim: cr16/d10v: localize translation funcs
Date: Tue, 10 Nov 2015 07:18:00 -0000	[thread overview]
Message-ID: <1447139875-2921-1-git-send-email-vapier@gentoo.org> (raw)

These functions are only used in the interp module, so there's no point
in exporting them and declaring them in the external sim interface.

Committed.
---
 include/gdb/ChangeLog  |  9 +++++++++
 include/gdb/sim-cr16.h | 23 -----------------------
 include/gdb/sim-d10v.h | 23 -----------------------
 sim/cr16/ChangeLog     |  6 ++++++
 sim/cr16/interp.c      |  6 +++---
 sim/d10v/ChangeLog     |  6 ++++++
 sim/d10v/interp.c      |  6 +++---
 7 files changed, 27 insertions(+), 52 deletions(-)

diff --git a/include/gdb/ChangeLog b/include/gdb/ChangeLog
index 4d992d2..57a83ce 100644
--- a/include/gdb/ChangeLog
+++ b/include/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2015-11-10  Mike Frysinger  <vapier@gentoo.org>
+
+	* sim-cr16.h (sim_cr16_translate_dmap_addr): Delete.
+	(sim_cr16_translate_imap_addr): Likewise.
+	(sim_cr16_translate_addr): Likewise.
+	* sim-d10v.h (sim_d10v_translate_dmap_addr): Delete.
+	(sim_d10v_translate_imap_addr): Likewise.
+	(sim_d10v_translate_addr): Likewise.
+
 2015-06-17  Mike Frysinger  <vapier@gentoo.org>
 
 	* callback.h (CB_TARGET_DEFS_MAP): Add name member.
diff --git a/include/gdb/sim-cr16.h b/include/gdb/sim-cr16.h
index 4d4da04..03f4b81 100644
--- a/include/gdb/sim-cr16.h
+++ b/include/gdb/sim-cr16.h
@@ -33,29 +33,6 @@ enum
     SIM_CR16_MEMORY_IMAP    = 0x10000000
   };
 
-extern unsigned long sim_cr16_translate_dmap_addr
-  (unsigned long offset,
-   int nr_bytes,
-   unsigned long *phys,
-   void *regcache,
-   unsigned long (*dmap_register) (void *regcache, int reg_nr));
-
-extern unsigned long sim_cr16_translate_imap_addr
-  (unsigned long offset,
-   int nr_bytes,
-   unsigned long *phys,
-   void *regcache,
-   unsigned long (*imap_register) (void *regcache, int reg_nr));
-
-extern unsigned long sim_cr16_translate_addr
-  (unsigned long vaddr,
-   int nr_bytes,
-   unsigned long *phys,
-   void *regcache,
-   unsigned long (*dmap_register) (void *regcache, int reg_nr),
-   unsigned long (*imap_register) (void *regcache, int reg_nr));
-
-
 /* The simulator makes use of the following register information. */
 
 enum sim_cr16_regs
diff --git a/include/gdb/sim-d10v.h b/include/gdb/sim-d10v.h
index 5040dd6..3416766 100644
--- a/include/gdb/sim-d10v.h
+++ b/include/gdb/sim-d10v.h
@@ -53,29 +53,6 @@ enum
     SIM_D10V_MEMORY_IMAP = 0x11000000
   };
 
-extern unsigned long sim_d10v_translate_dmap_addr
-  (unsigned long offset,
-   int nr_bytes,
-   unsigned long *phys,
-   void *regcache,
-   unsigned long (*dmap_register) (void *regcache, int reg_nr));
-
-extern unsigned long sim_d10v_translate_imap_addr
-  (unsigned long offset,
-   int nr_bytes,
-   unsigned long *phys,
-   void *regcache,
-   unsigned long (*imap_register) (void *regcache, int reg_nr));
-
-extern unsigned long sim_d10v_translate_addr
-  (unsigned long vaddr,
-   int nr_bytes,
-   unsigned long *phys,
-   void *regcache,
-   unsigned long (*dmap_register) (void *regcache, int reg_nr),
-   unsigned long (*imap_register) (void *regcache, int reg_nr));
-
-
 /* The simulator makes use of the following register information. */
 
 enum sim_d10v_regs
diff --git a/sim/cr16/ChangeLog b/sim/cr16/ChangeLog
index e81bb58..ccc4abb 100644
--- a/sim/cr16/ChangeLog
+++ b/sim/cr16/ChangeLog
@@ -1,3 +1,9 @@
+2015-11-10  Mike Frysinger  <vapier@gentoo.org>
+
+	* interp.c (sim_cr16_translate_dmap_addr): Mark static.
+	(sim_cr16_translate_imap_addr): Likewise.
+	(sim_cr16_translate_addr): Likewise.
+
 2015-06-23  Mike Frysinger  <vapier@gentoo.org>
 
 	* configure: Regenerate.
diff --git a/sim/cr16/interp.c b/sim/cr16/interp.c
index 6e31e1a..5b3f5bb 100644
--- a/sim/cr16/interp.c
+++ b/sim/cr16/interp.c
@@ -426,7 +426,7 @@ imap_register (void *regcache, int reg_nr)
 /* Given a virtual address in the DMAP address space, translate it
    into a physical address. */
 
-unsigned long
+static unsigned long
 sim_cr16_translate_dmap_addr (unsigned long offset,
                               int nr_bytes,
                               unsigned long *phys,
@@ -489,7 +489,7 @@ sim_cr16_translate_dmap_addr (unsigned long offset,
 /* Given a virtual address in the IMAP address space, translate it
    into a physical address. */
 
-unsigned long
+static unsigned long
 sim_cr16_translate_imap_addr (unsigned long offset,
                               int nr_bytes,
                               unsigned long *phys,
@@ -542,7 +542,7 @@ sim_cr16_translate_imap_addr (unsigned long offset,
   return nr_bytes;
 }
 
-unsigned long
+static unsigned long
 sim_cr16_translate_addr (unsigned long memaddr, int nr_bytes,
                          unsigned long *targ_addr, void *regcache,
                          unsigned long (*dmap_register) (void *regcache,
diff --git a/sim/d10v/ChangeLog b/sim/d10v/ChangeLog
index aeef0a4..765d7a5 100644
--- a/sim/d10v/ChangeLog
+++ b/sim/d10v/ChangeLog
@@ -1,3 +1,9 @@
+2015-11-10  Mike Frysinger  <vapier@gentoo.org>
+
+	* interp.c (sim_d10v_translate_dmap_addr): Mark static.
+	(sim_d10v_translate_imap_addr): Likewise.
+	(sim_d10v_translate_addr): Likewise.
+
 2015-06-23  Mike Frysinger  <vapier@gentoo.org>
 
 	* configure: Regenerate.
diff --git a/sim/d10v/interp.c b/sim/d10v/interp.c
index b975561..9c059f7 100644
--- a/sim/d10v/interp.c
+++ b/sim/d10v/interp.c
@@ -388,7 +388,7 @@ set_spu_register  (unsigned long value)
 /* Given a virtual address in the DMAP address space, translate it
    into a physical address. */
 
-unsigned long
+static unsigned long
 sim_d10v_translate_dmap_addr (unsigned long offset,
 			      int nr_bytes,
 			      unsigned long *phys,
@@ -448,7 +448,7 @@ sim_d10v_translate_dmap_addr (unsigned long offset,
 /* Given a virtual address in the IMAP address space, translate it
    into a physical address. */
 
-unsigned long
+static unsigned long
 sim_d10v_translate_imap_addr (unsigned long offset,
 			      int nr_bytes,
 			      unsigned long *phys,
@@ -501,7 +501,7 @@ sim_d10v_translate_imap_addr (unsigned long offset,
   return nr_bytes;
 }
 
-unsigned long
+static unsigned long
 sim_d10v_translate_addr (unsigned long memaddr,
 			 int nr_bytes,
 			 unsigned long *targ_addr,
-- 
2.6.2

                 reply	other threads:[~2015-11-10  7:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447139875-2921-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).