From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114363 invoked by alias); 18 Nov 2015 16:49:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114346 invoked by uid 89); 18 Nov 2015 16:49:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Nov 2015 16:49:45 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 95669C1FCCE6; Wed, 18 Nov 2015 16:40:11 +0000 (UTC) Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAIGe2QD030267; Wed, 18 Nov 2015 11:40:10 -0500 From: Pedro Alves To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 6/6] [C++] Default to -Werror in C++ mode too Date: Wed, 18 Nov 2015 16:49:00 -0000 Message-Id: <1447864802-24016-7-git-send-email-palves@redhat.com> In-Reply-To: <1447864802-24016-1-git-send-email-palves@redhat.com> References: <1447864802-24016-1-git-send-email-palves@redhat.com> X-SW-Source: 2015-11/txt/msg00372.txt.bz2 Both x86_64 GNU/Linux and x86_64 mingw-w64 build cleanly with --enable-targets=all. This enables -Werror by default in C++ mode too, in order to let the buildbot catch C++ build regressions for us. gdb/ChangeLog: 2015-11-18 Pedro Alves * configure.ac (ERROR_ON_WARNING): Don't check whether in C++ mode. * configure: Regenerate. gdb/gdbserver/ChangeLog: 2015-11-18 Pedro Alves * configure.ac (ERROR_ON_WARNING): Don't check whether in C++ mode. * configure: Regenerate. --- gdb/configure | 7 ++----- gdb/configure.ac | 7 ++----- gdb/gdbserver/configure | 3 +-- gdb/gdbserver/configure.ac | 3 +-- 4 files changed, 6 insertions(+), 14 deletions(-) diff --git a/gdb/configure b/gdb/configure index 8ef3cf2..249a399 100755 --- a/gdb/configure +++ b/gdb/configure @@ -14293,11 +14293,8 @@ if test "${enable_werror+set}" = set; then : fi -# Enable -Werror by default when using gcc in C mode. Leave it off -# for C++ until we're warning clean. Turn it off for releases. -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \ - && test x"$enable_build_with_cxx" != x"yes" \ - && $development; then +# Enable -Werror by default when using gcc. Turn it off for releases. +if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then ERROR_ON_WARNING=yes fi diff --git a/gdb/configure.ac b/gdb/configure.ac index 29d0b63..ebd797b 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1932,11 +1932,8 @@ AC_ARG_ENABLE(werror, *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;; esac]) -# Enable -Werror by default when using gcc in C mode. Leave it off -# for C++ until we're warning clean. Turn it off for releases. -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \ - && test x"$enable_build_with_cxx" != x"yes" \ - && $development; then +# Enable -Werror by default when using gcc. Turn it off for releases. +if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then ERROR_ON_WARNING=yes fi diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index 4b9aa95..87dfda0 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -6106,8 +6106,7 @@ if test "${enable_werror+set}" = set; then : fi -# Enable -Werror by default when using gcc in C mode. Leave it off -# for C++ until we're warning clean. Turn it off for releases. +# Enable -Werror by default when using gcc. Turn it off for releases. if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \ && test x"$enable_build_with_cxx" != x"yes" \ && $development; then diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac index 0fe0a35..d50d0f1 100644 --- a/gdb/gdbserver/configure.ac +++ b/gdb/gdbserver/configure.ac @@ -157,8 +157,7 @@ AC_ARG_ENABLE(werror, *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;; esac]) -# Enable -Werror by default when using gcc in C mode. Leave it off -# for C++ until we're warning clean. Turn it off for releases. +# Enable -Werror by default when using gcc. Turn it off for releases. if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \ && test x"$enable_build_with_cxx" != x"yes" \ && $development; then -- 1.9.3