* [PATCH] sim: bfin: avoid stack error under asan [committed]
@ 2015-12-26 23:24 Mike Frysinger
0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2015-12-26 23:24 UTC (permalink / raw)
To: gdb-patches
We set up an array of 3 elements and then index into it with a 2bit
value. We check the range before we actually use the pointer, but
the indexing is enough to make asan upset, so just stuff a fourth
value in there to keep things simple.
---
sim/bfin/ChangeLog | 4 ++++
sim/bfin/bfin-sim.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/sim/bfin/ChangeLog b/sim/bfin/ChangeLog
index 6717fcc..fb00c8b 100644
--- a/sim/bfin/ChangeLog
+++ b/sim/bfin/ChangeLog
@@ -1,5 +1,9 @@
2015-12-26 Mike Frysinger <vapier@gentoo.org>
+ * bfin-sim.c (decode_LDST_0): Add 4th element to posts array.
+
+2015-12-26 Mike Frysinger <vapier@gentoo.org>
+
* interp.c (sim_create_inferior): Update comment and argv check.
2015-12-25 Mike Frysinger <vapier@gentoo.org>
diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c
index b6acb4e..9737bc1 100644
--- a/sim/bfin/bfin-sim.c
+++ b/sim/bfin/bfin-sim.c
@@ -3292,7 +3292,7 @@ decode_LDST_0 (SIM_CPU *cpu, bu16 iw0)
int aop = ((iw0 >> LDST_aop_bits) & LDST_aop_mask);
int reg = ((iw0 >> LDST_reg_bits) & LDST_reg_mask);
int ptr = ((iw0 >> LDST_ptr_bits) & LDST_ptr_mask);
- const char * const posts[] = { "++", "--", "" };
+ const char * const posts[] = { "++", "--", "", "<INV>" };
const char *post = posts[aop];
const char *ptr_name = get_preg_name (ptr);
--
2.6.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-26 23:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-26 23:24 [PATCH] sim: bfin: avoid stack error under asan [committed] Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).