* [PATCH] Fix C++ build error by casting void *
@ 2016-01-14 12:20 Yao Qi
0 siblings, 0 replies; only message in thread
From: Yao Qi @ 2016-01-14 12:20 UTC (permalink / raw)
To: gdb-patches
Two recent patches breaks GDB C++ mode build,
https://sourceware.org/ml/gdb-patches/2016-01/msg00150.html
https://sourceware.org/ml/gdb-patches/2016-01/msg00086.html
gdb/remote.c: In function 'int remote_set_syscall_catchpoint(target_ops*, int, int, int, int, int*)':
gdb/remote.c:2036:39: error: invalid conversion from 'void*' to 'char*' [-fpermissive]
catch_packet = xmalloc (maxpktsz);
^
gdb/thread.c: In function 'int do_captured_thread_select(ui_out*, void*)':
gdb/git/gdb/thread.c:1999:24: error: invalid conversion from 'void*' to 'const char*' [-fpermissive]
const char *tidstr = tidstr_v;
^
this patch fixes them by casting void * to the right type. I'll push
it in.
gdb:
2016-01-14 Yao Qi <yao.qi@linaro.org>
* remote.c (remote_set_syscall_catchpoint): Cast to char *.
* thread.c (do_captured_thread_select): Cast to const char *.
---
gdb/remote.c | 2 +-
gdb/thread.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 8b63708..d5701e3 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -2033,7 +2033,7 @@ remote_set_syscall_catchpoint (struct target_ops *self,
big, fallback on the non-selective packet. */
const int maxpktsz = strlen ("QCatchSyscalls:1") + n_sysno * 9 + 1;
- catch_packet = xmalloc (maxpktsz);
+ catch_packet = (char *) xmalloc (maxpktsz);
strcpy (catch_packet, "QCatchSyscalls:1");
if (!any_count)
{
diff --git a/gdb/thread.c b/gdb/thread.c
index cdd2a2f..b3b3995 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -1996,7 +1996,7 @@ show_print_thread_events (struct ui_file *file, int from_tty,
static int
do_captured_thread_select (struct ui_out *uiout, void *tidstr_v)
{
- const char *tidstr = tidstr_v;
+ const char *tidstr = (const char *) tidstr_v;
struct thread_info *tp;
if (ui_out_is_mi_like_p (uiout))
--
1.9.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-14 12:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-14 12:20 [PATCH] Fix C++ build error by casting void * Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).