From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: [PATCH v3 3/6] Display per-thread information for threads in FreeBSD cores.
Date: Mon, 18 Jan 2016 02:28:00 -0000 [thread overview]
Message-ID: <1453084047-16175-4-git-send-email-jhb@FreeBSD.org> (raw)
In-Reply-To: <1453084047-16175-1-git-send-email-jhb@FreeBSD.org>
Display the LWP ID of each thread in a FreeBSD core. Extract thread names
from the per-thread THRMISC note.
gdb/ChangeLog:
* fbsd_tdep.c (fbsd_core_pid_to_str): New function.
(fbsd_init_abi): Add "core_pid_to_str" gdbarch method.
---
gdb/ChangeLog | 5 +++++
gdb/fbsd-tdep.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fe8fd6c..8f28959 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-01-16 John Baldwin <jhb@FreeBSD.org>
+
+ * fbsd_tdep.c (fbsd_core_pid_to_str): New function.
+ (fbsd_init_abi): Add "core_pid_to_str" gdbarch method.
+
2016-01-15 Sandra Loosemore <sandra@codesourcery.com>
* charset.c [PHONY_ICONV] (GDB_DEFAULT_HOST_CHARSET):
diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c
index 0ef94d6..88342cd 100644
--- a/gdb/fbsd-tdep.c
+++ b/gdb/fbsd-tdep.c
@@ -28,6 +28,52 @@
#include "fbsd-tdep.h"
+/* This is how we want PTIDs from core files to be printed. */
+
+static char *
+fbsd_core_pid_to_str (struct gdbarch *gdbarch, ptid_t ptid)
+{
+ static char buf[80];
+ struct bfd_section *section;
+ bfd_size_type size;
+ char sectionstr[32];
+
+ if (ptid_get_lwp (ptid) != 0)
+ {
+ xsnprintf (sectionstr, sizeof sectionstr, ".thrmisc/%ld",
+ ptid_get_lwp (ptid));
+ section = bfd_get_section_by_name (core_bfd, sectionstr);
+ if (section != NULL && bfd_section_size (core_bfd, section) > 0)
+ {
+ char *name;
+
+ size = bfd_section_size (core_bfd, section);
+ name = alloca (size + 1);
+ if (bfd_get_section_contents (core_bfd, section, name, (file_ptr) 0,
+ size)
+ && name[0] != '\0')
+ {
+ name[size] = '\0';
+
+ /* Note that each thread will report the process command
+ as its thread name instead of an empty name if a name
+ has not been set explicitly. Return a NULL name in
+ that case. */
+ if (strcmp (name, elf_tdata (core_bfd)->core->program) != 0)
+ {
+ xsnprintf (buf, sizeof buf, "LWP %ld \"%s\"",
+ ptid_get_lwp (ptid), name);
+ return buf;
+ }
+ }
+ }
+ xsnprintf (buf, sizeof buf, "LWP %ld", ptid_get_lwp (ptid));
+ return buf;
+ }
+
+ return normal_pid_to_str (ptid);
+}
+
static int
find_signalled_thread (struct thread_info *info, void *data)
{
@@ -132,5 +178,6 @@ fbsd_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, int *note_size)
void
fbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
+ set_gdbarch_core_pid_to_str (gdbarch, fbsd_core_pid_to_str);
set_gdbarch_make_corefile_notes (gdbarch, fbsd_make_corefile_notes);
}
--
2.7.0
next prev parent reply other threads:[~2016-01-18 2:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 2:28 [PATCH v3 0/6] Support kernel-backed user threads on FreeBSD John Baldwin
2016-01-18 2:28 ` [PATCH v3 4/6] Use LWP IDs with ptrace register requests " John Baldwin
2016-01-18 12:32 ` Pedro Alves
2016-01-18 2:28 ` [PATCH v3 5/6] Add support for LWP-based threads " John Baldwin
2016-01-18 12:37 ` Pedro Alves
2016-01-18 16:00 ` Eli Zaretskii
2016-01-18 17:06 ` John Baldwin
2016-01-18 2:28 ` John Baldwin [this message]
2016-01-18 2:28 ` [PATCH v3 1/6] Add support to readelf for reading FreeBSD ELF core notes John Baldwin
2016-01-19 16:50 ` Christophe Lyon
2016-01-19 17:10 ` John Baldwin
2016-01-19 17:12 ` Pedro Alves
2016-01-18 2:28 ` [PATCH v3 2/6] Add a psuedosection for the NT_FREEBSD_THRMISC note John Baldwin
2016-01-18 12:38 ` Pedro Alves
2016-01-18 17:06 ` John Baldwin
2016-01-18 2:28 ` [PATCH v3 6/6] Dump register notes for each thread when generating a FreeBSD core John Baldwin
2016-01-18 12:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453084047-16175-4-git-send-email-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).