From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] Use a separate variable for the size passed to sysctl.
Date: Tue, 19 Jan 2016 18:29:00 -0000 [thread overview]
Message-ID: <1453227896-65820-1-git-send-email-jhb@FreeBSD.org> (raw)
This fixes a sign mismatch warning.
gdb/ChangeLog:
* fbsd-tdep.c (fbsd_pid_to_exec_file): Use new "buflen" instead of
"len" with sysctl.
---
gdb/ChangeLog | 5 +++++
gdb/fbsd-nat.c | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e8277f3..aa7e0fa 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2016-01-19 John Baldwin <jhb@FreeBSD.org>
+ * fbsd-tdep.c (fbsd_pid_to_exec_file): Use new "buflen" instead of
+ "len" with sysctl.
+
+2016-01-19 John Baldwin <jhb@FreeBSD.org>
+
* fbsd-tdep.c (find_stop_signal): Remove.
(struct fbsd_collect_regset_section_cb) <lwp>: New field.
<stop_signal>: New field.
diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index d2ec527..6504625 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -48,13 +48,15 @@ fbsd_pid_to_exec_file (struct target_ops *self, int pid)
char name[PATH_MAX];
#ifdef KERN_PROC_PATHNAME
+ size_t buflen;
int mib[4];
mib[0] = CTL_KERN;
mib[1] = KERN_PROC;
mib[2] = KERN_PROC_PATHNAME;
mib[3] = pid;
- if (sysctl (mib, 4, buf, &len, NULL, 0) == 0)
+ buflen = sizeof buf;
+ if (sysctl (mib, 4, buf, &buflen, NULL, 0) == 0)
return buf;
#endif
--
2.7.0
next reply other threads:[~2016-01-19 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 18:29 John Baldwin [this message]
2016-01-19 19:18 ` Pedro Alves
2016-01-19 19:36 ` John Baldwin
2016-01-19 22:53 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453227896-65820-1-git-send-email-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).