From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] Reword the string description of native FreeBSD ptids.
Date: Thu, 21 Jan 2016 18:55:00 -0000 [thread overview]
Message-ID: <1453402207-15868-1-git-send-email-jhb@FreeBSD.org> (raw)
The prior format led to confusing messages when threads were created
or added such as "[New process 14757, LWP 100537]". The new format
reports this as "[New LWP 100434 of process 15652]".
gdb/ChangeLog:
* fbsd-nat.c (fbsd_pid_to_str): Adjust string format.
---
gdb/ChangeLog | 4 ++++
gdb/fbsd-nat.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 45d8ef9..008a6cd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2016-01-21 John Baldwin <jhb@FreeBSD.org>
+
+ * fbsd-nat.c (fbsd_pid_to_str): Adjust string format.
+
2016-01-21 Andrew Burgess <andrew.burgess@embecosm.com>
* disasm.c (maybe_add_dis_line_entry): Rename to...
diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index e7ca0e6..bdf078e 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -303,7 +303,7 @@ fbsd_pid_to_str (struct target_ops *ops, ptid_t ptid)
static char buf[64];
int pid = ptid_get_pid (ptid);
- xsnprintf (buf, sizeof buf, "process %d, LWP %d", pid, lwp);
+ xsnprintf (buf, sizeof buf, "LWP %d of process %d", lwp, pid);
return buf;
}
--
2.7.0
I believe I copied the earlier format from the bsd-uthread.c target.
Linux only reports the LWP. Some other targets report both the process
and thread ID (such as Darwin).
next reply other threads:[~2016-01-21 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 18:55 John Baldwin [this message]
2016-01-22 10:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453402207-15868-1-git-send-email-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).