From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/2] [GDBserver] Check input interrupt after reading in a packet
Date: Tue, 26 Jan 2016 09:59:00 -0000 [thread overview]
Message-ID: <1453802339-20401-2-git-send-email-yao.qi@linaro.org> (raw)
In-Reply-To: <1453802339-20401-1-git-send-email-yao.qi@linaro.org>
GDBserver may read some packet together with '\003' in one go. We've
already checked '\003' first when reading packet by my patch,
Check input interrupt first when reading packet
https://sourceware.org/ml/gdb-patches/2016-01/msg00057.html
but if we don't check '\003' *after* each packet, the interrupt will
be processed next time GDBserver reads from the buffer, so that the
interrupt isn't processed in time. For example, GDB sends vCont;c and
interrupt (see gdb.base/interrupt-noterm.exp), we'll resume the
inferior and wait once packet vCont;c is seen. If we don't check the
interrupt character after vCont;c packet, interrupt character will stay
in the buffer unattended until GDBserver returns from the wait, which
may take a while. Note that since we've read '\003' from file
descriptor, SIGIO signal handler input_interrupt doesn't help either.
This issue can be exposed by hacking the end of getpkt like
@@ -1041,6 +1050,9 @@ getpkt (char *buf)
}
}
+ if (readchar_bufcnt > 0)
+ gdb_assert (*readchar_bufp != '\003');
+
return bp - buf;
}
and this can trigger internal error,
(gdb) PASS: gdb.base/interrupt-noterm.exp: interrupt
Remote connection closed^M
(gdb) FAIL: gdb.base/interrupt-noterm.exp: inferior received SIGINT
Remote debugging from host 10.2.206.40^M
/home/yao/SourceCode/gnu/gdb/git/gdb/gdbserver/remote-utils.c:1054: A problem internal to GDBserver has been detected.^M
getpkt: Assertion `*readchar_bufp != '\003'' failed.^M
This patch is to peek the buffer, if it is '\003', consume it and call
*the_target->request_interrupt.
gdb/gdbserver:
2016-01-26 Yao Qi <yao.qi@linaro.org>
* remote-utils.c (getpkt): If the buffer isn't empty, and the
first character is '\003', call *the_target->request_interrupt.
---
gdb/gdbserver/remote-utils.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 292197a..000457d 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -1041,6 +1041,15 @@ getpkt (char *buf)
}
}
+ /* The '\003' may appear after some packet, and check it in the buffer,
+ so that we can process the interrupt in time. */
+ if (readchar_bufcnt > 0 && *readchar_bufp == '\003')
+ {
+ /* Consume the interrupt character in the buffer. */
+ readchar ();
+ (*the_target->request_interrupt) ();
+ }
+
return bp - buf;
}
--
1.9.1
next prev parent reply other threads:[~2016-01-26 9:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 16:29 [PATCH] Fix fail in gdb.base/interrupt-noterm.exp Yao Qi
2016-01-22 16:47 ` Pedro Alves
2016-01-22 17:14 ` Yao Qi
2016-01-22 17:35 ` Pedro Alves
2016-01-22 18:30 ` Pedro Alves
2016-01-25 9:30 ` Yao Qi
2016-01-25 10:43 ` Pedro Alves
2016-01-26 9:59 ` [PATCH 0/2 V2] Fix a " Yao Qi
2016-01-26 9:59 ` [PATCH 2/2] [GDBserver] Block and unblock SIGIO Yao Qi
2016-01-26 12:01 ` Pedro Alves
2016-01-26 13:55 ` Yao Qi
2016-01-26 9:59 ` Yao Qi [this message]
2016-01-26 11:42 ` [PATCH 1/2] [GDBserver] Check input interrupt after reading in a packet Pedro Alves
2016-01-26 13:53 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453802339-20401-2-git-send-email-yao.qi@linaro.org \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).