From: Don Breazeal <donb@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 3/3] PR remote/19496, timeout in forking-threads-plus-bkpt
Date: Thu, 28 Jan 2016 00:48:00 -0000 [thread overview]
Message-ID: <1453942111-1215-4-git-send-email-donb@codesourcery.com> (raw)
In-Reply-To: <1453942111-1215-1-git-send-email-donb@codesourcery.com>
This patch addresses a failure in
gdb.threads/forking-threads-plus-breakpoint.exp:
FAIL: gdb.threads/forking-threads-plus-breakpoint.exp: cond_bp_target=1:
detach_on_fork=on: inferior 1 exited (timeout)
Cause:
A fork event was reported to GDB before GDB knew about the parent thread,
followed immediately by a breakpoint event in a different thread. The
parent thread was subsequently added via remote_notice_new_inferior in
process_stop_reply, but when the thread was added the thread_info.state
was set to THREAD_STOPPED. The fork event was then handled correctly,
but when the fork parent was resumed via a call to keep_going, the state
was unchanged.
The breakpoint event was then handled, which caused all the non-breakpoint
threads to be stopped. When the breakpoint thread was resumed, all the
non-breakpoint threads were resumed via infrun.c:restart_threads. Our old
fork parent wasn't restarted, because it still had thread_info.state set to
THREAD_STOPPED. Ultimately the program under debug hung waiting for a
pthread_join while the old fork parent was stopped forever by GDB.
Fix:
Add a call to set_running just before resuming the fork parent in
infrun.c:handle_inferior_event_1. The call could be put elsewhere
(e.g. in keep_going) but this approach makes the change for the case
of resuming after a fork event, without potential side-effects for
other cases where keep_going is called.
Tested on x86_64 Linux and Nios II Linux target with x86 Linux host.
Thanks,
--Don
gdb/ChangeLog:
2016-01-27 Don Breazeal <donb@codesourcery.com>
PR remote/19496
* infrun.c (handle_inferior_event_1): Call set_running before
resuming.
---
gdb/infrun.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 15210c9..e324864 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -5232,7 +5232,13 @@ Cannot fill $_exitsignal with the correct signal number.\n"));
ecs->ptid = inferior_ptid;
if (should_resume)
- keep_going (ecs);
+ {
+ /* Make sure the thread is marked as running. If the event
+ occurred in the thread before we added it, it may have
+ never been marked running. */
+ set_running (inferior_ptid, 1);
+ keep_going (ecs);
+ }
else
stop_waiting (ecs);
return;
--
1.8.1.1
next prev parent reply other threads:[~2016-01-28 0:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 0:48 [PATCH 0/3] PR remote/19496, remote fork failures Don Breazeal
2016-01-28 0:48 ` [PATCH 1/3] PR remote/19496, internal err forking-threads-plus-bkpt Don Breazeal
2016-02-01 19:26 ` [pushed] Test gdb.threads/forking-threads-plus-breakpoint.exp with, displaced stepping off (Re: [PATCH 1/3] PR remote/19496, internal err forking-threads-plus-bkpt) Pedro Alves
2016-02-01 20:38 ` [PATCH 1/3] PR remote/19496, internal err forking-threads-plus-bkpt Pedro Alves
2016-02-11 0:26 ` [PATCH v2 " Don Breazeal
2016-02-12 20:15 ` Pedro Alves
2016-02-16 17:21 ` Don Breazeal
2016-01-28 0:48 ` Don Breazeal [this message]
2016-02-01 12:05 ` [PATCH 3/3] PR remote/19496, timeout in forking-threads-plus-bkpt Pedro Alves
2016-02-01 19:29 ` Don Breazeal
2016-02-01 20:09 ` Pedro Alves
2016-02-11 0:28 ` [PATCH v2 " Don Breazeal
2016-02-25 17:29 ` [PING]Re: " Don Breazeal
2016-03-03 18:20 ` [PING] " Don Breazeal
2016-03-14 21:30 ` Don Breazeal
2016-03-15 15:30 ` Pedro Alves
2016-03-16 17:29 ` Don Breazeal
2016-03-16 22:51 ` Don Breazeal
2016-03-17 10:38 ` Pedro Alves
2016-02-11 0:28 ` [PATCH v2 2/3] PR remote/19496, interrupted syscall " Don Breazeal
2016-02-25 17:28 ` Don Breazeal
2016-03-03 18:19 ` [PING] " Don Breazeal
2016-03-14 21:29 ` Don Breazeal
2016-03-15 12:55 ` Pedro Alves
2016-03-16 18:26 ` Don Breazeal
2016-03-16 18:33 ` Pedro Alves
2016-03-16 22:18 ` Don Breazeal
2016-01-28 0:48 ` [PATCH " Don Breazeal
2016-02-01 19:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453942111-1215-4-git-send-email-donb@codesourcery.com \
--to=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).