From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH 0/3] Minor refactorings in arm-tdep.c instruction decoding
Date: Wed, 10 Feb 2016 16:17:00 -0000 [thread overview]
Message-ID: <1455121027-27061-1-git-send-email-simon.marchi@ericsson.com> (raw)
I am currently working on extracting the instruction decoding from the
displaced stepping support in arm-tdep.c, in order to share the functionality
with the upcoming fast tracepoint support. I did a few refactors that helped
me correlate the code with the ARM Architecture Reference Manual. I think the
change helps readability in general, and especially when you have the manual
open on the side.
The idea is to follow the the order of the manual, use the same names and do
the same "checks" (avoid using unnecessary shortcuts that make the code more
cryptic).
Simon Marchi (3):
arm-tdep.c: Refactor arm_process_displaced_insn
arm-tdep.c: Refactor arm_decode_dp_misc
arm-tdep.c: Refactor arm_decode_media
gdb/arm-tdep.c | 171 ++++++++++++++++++++++++++++++++++++++++-----------------
1 file changed, 121 insertions(+), 50 deletions(-)
--
2.5.1
next reply other threads:[~2016-02-10 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 16:17 Simon Marchi [this message]
2016-02-10 16:17 ` [PATCH 2/3] arm-tdep.c: Refactor arm_decode_dp_misc Simon Marchi
2016-02-11 11:52 ` Yao Qi
2016-02-11 17:10 ` Yao Qi
2016-02-11 17:18 ` Simon Marchi
2016-02-10 16:17 ` [PATCH 1/3] arm-tdep.c: Refactor arm_process_displaced_insn Simon Marchi
2016-02-11 11:22 ` Yao Qi
2016-02-11 16:59 ` Simon Marchi
2016-02-12 16:56 ` Yao Qi
2016-02-10 16:17 ` [PATCH 3/3] arm-tdep.c: Refactor arm_decode_media Simon Marchi
2016-02-11 11:58 ` Yao Qi
2016-02-11 11:17 ` [PATCH 0/3] Minor refactorings in arm-tdep.c instruction decoding Yao Qi
2016-02-16 15:26 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455121027-27061-1-git-send-email-simon.marchi@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).