From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100664 invoked by alias); 10 Feb 2016 16:17:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100615 invoked by uid 89); 10 Feb 2016 16:17:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=shortcuts, displaced X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 10 Feb 2016 16:17:21 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id DF.29.32102.8726BB65; Wed, 10 Feb 2016 17:16:56 +0100 (CET) Received: from elxcz23q12-y4.dyn.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.78) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 10 Feb 2016 11:17:11 -0500 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 0/3] Minor refactorings in arm-tdep.c instruction decoding Date: Wed, 10 Feb 2016 16:17:00 -0000 Message-ID: <1455121027-27061-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00300.txt.bz2 I am currently working on extracting the instruction decoding from the displaced stepping support in arm-tdep.c, in order to share the functionality with the upcoming fast tracepoint support. I did a few refactors that helped me correlate the code with the ARM Architecture Reference Manual. I think the change helps readability in general, and especially when you have the manual open on the side. The idea is to follow the the order of the manual, use the same names and do the same "checks" (avoid using unnecessary shortcuts that make the code more cryptic). Simon Marchi (3): arm-tdep.c: Refactor arm_process_displaced_insn arm-tdep.c: Refactor arm_decode_dp_misc arm-tdep.c: Refactor arm_decode_media gdb/arm-tdep.c | 171 ++++++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 121 insertions(+), 50 deletions(-) -- 2.5.1