[PATCH V2 2/2] testsuite: Remove unnecessarry code in fortran vla-history test.

[PATCH V2 2/2] testsuite: Remove unnecessarry code in fortran vla-history test.

[Bernhard Heckel]

testsuite: Remove unnecessarry code in fortran vla-history test.

2016-02-25  Bernhard Heckel  <bernhard.heckel@intel.com>

gdb/Changelog:

     * vla-history.exp: Remove breakpoint.

---
 gdb/testsuite/gdb.fortran/vla-history.exp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gdb/testsuite/gdb.fortran/vla-history.exp b/gdb/testsuite/gdb.fortran/vla-history.exp
index bb2f84b..2012961 100644
--- a/gdb/testsuite/gdb.fortran/vla-history.exp
+++ b/gdb/testsuite/gdb.fortran/vla-history.exp
@@ -30,9 +30,6 @@ gdb_breakpoint [gdb_get_line_number "vla1-init"]
 gdb_continue_to_breakpoint "vla1-init"
 gdb_test "print vla1" " = <not allocated>" "print non-allocated vla1"
 
-gdb_breakpoint [gdb_get_line_number "vla2-allocated"]
-gdb_continue_to_breakpoint "vla2-allocated"
-
 gdb_breakpoint [gdb_get_line_number "vla1-filled"]
 gdb_continue_to_breakpoint "vla1-filled"
 with_timeout_factor 2 {
-- 
2.7.1.339.g0233b80

[PATCH V2 1/2] testsuite: Fix timeout issues during print of vla-arrays.

[Bernhard Heckel]

From: "bernhard.heckel" <bernhard.heckel@intel.com>

Printing and resolving of dynamic array's causes sporadic timeout issues on loaded systems.

2016-02-12  Bernhard Heckel  <bernhard.heckel@intel.com>

gdb/Changelog:

     * vla-history.exp: Lookup array elements and printing exceeds timeout.


Conflicts:

	gdb/testsuite/gdb.fortran/vla-history.exp
	gdb/testsuite/gdb.fortran/vla-value.exp
---
 gdb/testsuite/gdb.fortran/vla-history.exp | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.fortran/vla-history.exp b/gdb/testsuite/gdb.fortran/vla-history.exp
index 1478e6b..bb2f84b 100644
--- a/gdb/testsuite/gdb.fortran/vla-history.exp
+++ b/gdb/testsuite/gdb.fortran/vla-history.exp
@@ -35,14 +35,18 @@ gdb_continue_to_breakpoint "vla2-allocated"
 
 gdb_breakpoint [gdb_get_line_number "vla1-filled"]
 gdb_continue_to_breakpoint "vla1-filled"
-gdb_test "print vla1" \
-  " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" \
-  "print vla1 filled"
+with_timeout_factor 2 {
+    gdb_test "print vla1" \
+      " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" \
+      "print vla1 filled"
+}
 
 # Try to access history values for full vla prints.
 gdb_test "print \$1" " = <not allocated>" "print \$1"
-gdb_test "print \$2" \
-  " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" "print \$2"
+with_timeout_factor 2 {
+    gdb_test "print \$2" \
+      " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" "print \$4"
+}
 
 gdb_breakpoint [gdb_get_line_number "vla2-filled"]
 gdb_continue_to_breakpoint "vla2-filled"
-- 
2.7.1.339.g0233b80

Re: [PATCH V2 1/2] testsuite: Fix timeout issues during print of vla-arrays.

[Luis Machado]

On 02/25/2016 10:08 AM, Bernhard Heckel wrote:
> From: "bernhard.heckel" <bernhard.heckel@intel.com>
>
> Printing and resolving of dynamic array's causes sporadic timeout issues on loaded systems.
>
> 2016-02-12  Bernhard Heckel  <bernhard.heckel@intel.com>
>
> gdb/Changelog:
>
>       * vla-history.exp: Lookup array elements and printing exceeds timeout.
>
>
> Conflicts:
>
> 	gdb/testsuite/gdb.fortran/vla-history.exp
> 	gdb/testsuite/gdb.fortran/vla-value.exp
> ---
>   gdb/testsuite/gdb.fortran/vla-history.exp | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.fortran/vla-history.exp b/gdb/testsuite/gdb.fortran/vla-history.exp
> index 1478e6b..bb2f84b 100644
> --- a/gdb/testsuite/gdb.fortran/vla-history.exp
> +++ b/gdb/testsuite/gdb.fortran/vla-history.exp
> @@ -35,14 +35,18 @@ gdb_continue_to_breakpoint "vla2-allocated"
>
>   gdb_breakpoint [gdb_get_line_number "vla1-filled"]
>   gdb_continue_to_breakpoint "vla1-filled"
> -gdb_test "print vla1" \
> -  " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" \
> -  "print vla1 filled"
> +with_timeout_factor 2 {
> +    gdb_test "print vla1" \
> +      " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" \
> +      "print vla1 filled"
> +}
>
>   # Try to access history values for full vla prints.
>   gdb_test "print \$1" " = <not allocated>" "print \$1"
> -gdb_test "print \$2" \
> -  " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" "print \$2"
> +with_timeout_factor 2 {
> +    gdb_test "print \$2" \
> +      " = \\( *\\( *\\( *1311, *1311, *1311,\[()1311, .\]*\\)" "print \$4"
> +}
>
>   gdb_breakpoint [gdb_get_line_number "vla2-filled"]
>   gdb_continue_to_breakpoint "vla2-filled"
>

Looks good to me.

Re: [PATCH V2 2/2] testsuite: Remove unnecessarry code in fortran vla-history test.

[Luis Machado]

On 02/25/2016 10:08 AM, Bernhard Heckel wrote:
> testsuite: Remove unnecessarry code in fortran vla-history test.
>
> 2016-02-25  Bernhard Heckel  <bernhard.heckel@intel.com>
>
> gdb/Changelog:
>
>       * vla-history.exp: Remove breakpoint.
>

This should go in gdb/testsuite/ChangeLog.

It should say gdb.fortran/vla-history.exp.

Looks good otherwise. Someone else should approve it though.

> ---
>   gdb/testsuite/gdb.fortran/vla-history.exp | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.fortran/vla-history.exp b/gdb/testsuite/gdb.fortran/vla-history.exp
> index bb2f84b..2012961 100644
> --- a/gdb/testsuite/gdb.fortran/vla-history.exp
> +++ b/gdb/testsuite/gdb.fortran/vla-history.exp
> @@ -30,9 +30,6 @@ gdb_breakpoint [gdb_get_line_number "vla1-init"]
>   gdb_continue_to_breakpoint "vla1-init"
>   gdb_test "print vla1" " = <not allocated>" "print non-allocated vla1"
>
> -gdb_breakpoint [gdb_get_line_number "vla2-allocated"]
> -gdb_continue_to_breakpoint "vla2-allocated"
> -
>   gdb_breakpoint [gdb_get_line_number "vla1-filled"]
>   gdb_continue_to_breakpoint "vla1-filled"
>   with_timeout_factor 2 {
>

Re: [PATCH V2 1/2] testsuite: Fix timeout issues during print of vla-arrays.

[Joel Brobecker]

> 2016-02-12  Bernhard Heckel  <bernhard.heckel@intel.com>
> 
> gdb/Changelog:
> 
>      * vla-history.exp: Lookup array elements and printing exceeds timeout.

This is OK.

> Conflicts:
> 
> 	gdb/testsuite/gdb.fortran/vla-history.exp
> 	gdb/testsuite/gdb.fortran/vla-value.exp

Please remove these from the commit log! ;-)

-- 
Joel

Re: [PATCH V2 2/2] testsuite: Remove unnecessarry code in fortran vla-history test.

[Joel Brobecker]

On Fri, Feb 26, 2016 at 11:49:57AM -0300, Luis Machado wrote:
> On 02/25/2016 10:08 AM, Bernhard Heckel wrote:
> >testsuite: Remove unnecessarry code in fortran vla-history test.
> >
> >2016-02-25  Bernhard Heckel  <bernhard.heckel@intel.com>
> >
> >gdb/Changelog:
> >
> >      * vla-history.exp: Remove breakpoint.
> >
> 
> This should go in gdb/testsuite/ChangeLog.
> 
> It should say gdb.fortran/vla-history.exp.
> 
> Looks good otherwise. Someone else should approve it though.

Right on the dot!

Official review: What Luis said... :-)

-- 
Joel

Re: [PATCH V2 2/2] testsuite: Remove unnecessarry code in fortran vla-history test.

[Heckel, Bernhard]

On 26/02/2016 17:45, Joel Brobecker wrote:
> On Fri, Feb 26, 2016 at 11:49:57AM -0300, Luis Machado wrote:
>> On 02/25/2016 10:08 AM, Bernhard Heckel wrote:
>>> testsuite: Remove unnecessarry code in fortran vla-history test.
>>>
>>> 2016-02-25  Bernhard Heckel  <bernhard.heckel@intel.com>
>>>
>>> gdb/Changelog:
>>>
>>>       * vla-history.exp: Remove breakpoint.
>>>
>> This should go in gdb/testsuite/ChangeLog.
>>
>> It should say gdb.fortran/vla-history.exp.
>>
>> Looks good otherwise. Someone else should approve it though.
> Right on the dot!
>
> Official review: What Luis said... :-)
>
Done and pushed.

Regards,
Bernhard

-- 

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH V2 1/2] testsuite: Fix timeout issues during print of vla-arrays.

[Heckel, Bernhard]

On 26/02/2016 17:44, Joel Brobecker wrote:
>> 2016-02-12  Bernhard Heckel  <bernhard.heckel@intel.com>
>>
>> gdb/Changelog:
>>
>>       * vla-history.exp: Lookup array elements and printing exceeds timeout.
> This is OK.
>
>> Conflicts:
>>
>> 	gdb/testsuite/gdb.fortran/vla-history.exp
>> 	gdb/testsuite/gdb.fortran/vla-value.exp
> Please remove these from the commit log! ;-)
>
Done and pushed.

Regards,
Bernhard

-- 

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928