From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12023 invoked by alias); 11 Sep 2014 17:54:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12007 invoked by uid 89); 11 Sep 2014 17:54:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailuogwhop.emc.com Received: from mailuogwhop.emc.com (HELO mailuogwhop.emc.com) (168.159.213.141) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 11 Sep 2014 17:54:26 +0000 Received: from maildlpprd05.lss.emc.com (maildlpprd05.lss.emc.com [10.253.24.37]) by mailuogwprd04.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s8BHsNwF025043 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 11 Sep 2014 13:54:24 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com s8BHsNwF025043 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com s8BHsNwF025043 Received: from mailhub.lss.emc.com (mailhubhoprd03.lss.emc.com [10.254.221.145]) by maildlpprd05.lss.emc.com (RSA Interceptor) for ; Thu, 11 Sep 2014 13:54:10 -0400 Received: from usendtaylorx2l.lss.emc.com (usendtaylorx2l.lss.emc.com [10.243.10.188]) by mailhub.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id s8BHsCTX000636 for ; Thu, 11 Sep 2014 13:54:12 -0400 Received: by usendtaylorx2l.lss.emc.com (Postfix, from userid 26043) id DC6865D26CE; Thu, 11 Sep 2014 13:54:10 -0400 (EDT) Received: from usendtaylorx2l (localhost [127.0.0.1]) by usendtaylorx2l.lss.emc.com (Postfix) with ESMTP id 3ED125D1628 for ; Thu, 11 Sep 2014 13:54:10 -0400 (EDT) From: David Taylor To: "gdb-patches@sourceware.org" Subject: two agent expression nits (one line each) Date: Thu, 11 Sep 2014 17:54:00 -0000 Message-ID: <14583.1410458050@usendtaylorx2l> X-EMM-MHVC: 1 X-RSA-Classifications: DLM_1, public X-Sentrion-Hostname: mailuogwprd04.lss.emc.com X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00365.txt.bz2 In gdb/doc/agentexpr.texi you''ll find the text: @item @code{setv} (0x2d) @var{n}: @result{} @var{v} Set trace state variable number @var{n} to the value found on the top of the stack. The stack is unchanged, so that the value is readily available if the assignment is part of a larger expression. The handling of @var{n} is as described for @code{getv}. The @item line and the following text do no agree with one another. I'm guessing that the text is correct, in which case this line: @item @code{setv} (0x2d) @var{n}: @result{} @var{v} should be changed to this: @item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} Additionally, in gdb/common/ax.def we find the line: DEFOP (setv, 2, 0, 0, 1, 0x2d) >From the comment earlier in the file: Each line is of the form: DEFOP (name, size, data_size, consumed, produced, opcode) [...] CONSUMED is the number of stack elements consumed. PRODUCED is the number of stack elements produced. which is saying that nothing is consumed and one item is produced. Both should be 0 or both should be 1. Setting them both to 1 seems better since if nothing is on the stack an error will occur. So, it should be changed to: DEFOP (setv, 2, 0, 1, 1, 0x2d) David