From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH] Fix gdb.mi/mi-breakpoint-changed.exp for remote targets
Date: Sun, 03 Apr 2016 18:30:00 -0000 [thread overview]
Message-ID: <1459708224-8253-1-git-send-email-simon.marchi@polymtl.ca> (raw)
The libraries are never downloaded to the target for the first test
(test_insert_delete_modify), so the executable can't run properly.
I also added some with_test_prefix to help differentiate between the
different test case phases.
gdb/testsuite/ChangeLog:
* gdb.mi/mi-breakpoint-changed.exp: Add some with_test_prefix.
(test_insert_delete_modify): Call mi_load_shlibs before trying to
run.
---
gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
index c12f8b8..cda8c4a 100644
--- a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
+++ b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
@@ -45,12 +45,15 @@ if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable $exec_opts] != ""
proc test_insert_delete_modify { } {
global mi_gdb_prompt
+ global lib_sl1 lib_sl2
gdb_exit
if [mi_gdb_start] {
continue
}
+ mi_load_shlibs $lib_sl1 $lib_sl2
+
mi_run_to_main
mi_gdb_test "break marker" \
@@ -150,7 +153,9 @@ proc test_insert_delete_modify { } {
}
}
-test_insert_delete_modify
+with_test_prefix "test_insert_delete_modify" {
+ test_insert_delete_modify
+}
# Test 'breakpoint-modified' notification is emited when pending breakpoints are
# resolved.
@@ -251,4 +256,6 @@ proc test_pending_resolved { } {
}
}
-test_pending_resolved
+with_test_prefix "test_pending_resolved" {
+ test_pending_resolved
+}
--
2.8.0
next reply other threads:[~2016-04-03 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 18:30 Simon Marchi [this message]
2016-04-04 9:23 ` Yao Qi
2016-04-04 14:33 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459708224-8253-1-git-send-email-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).