From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH 4/4] Fix solib-display.exp remote check
Date: Wed, 06 Apr 2016 03:15:00 -0000 [thread overview]
Message-ID: <1459912543-15328-4-git-send-email-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca>
This test currently uses [is_remote target] to check if the test is
supported. This is not quite correct, as you could run the test with an
extended-remote gdbserver configuration and a remote target [1]. The
test uses "run", which makes it inappropriate for stub-like targets, so
that's what it should check instead.
[1] I managed to do it, but the current testsuite code does not make it
easy to make such a board file...
gdb/testsuite/ChangeLog:
* gdb.base/solib-display.exp: Don't check for [is_remote target],
check for $use_gdb_stub instead.
---
gdb/testsuite/gdb.base/solib-display.exp | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/solib-display.exp b/gdb/testsuite/gdb.base/solib-display.exp
index 7f65617..42ad08c 100644
--- a/gdb/testsuite/gdb.base/solib-display.exp
+++ b/gdb/testsuite/gdb.base/solib-display.exp
@@ -28,7 +28,7 @@
# (and thus aren't affected by shared library unloading) are not
# disabled prematurely.
-if { [skip_shlib_tests] || [is_remote target] } {
+if { [skip_shlib_tests] } {
return 0
}
@@ -72,6 +72,11 @@ foreach libsepdebug {NO IN SEP} { with_test_prefix "$libsepdebug" {
clean_restart $executable
+ # This test uses run, so it's pointless to test on stub targets.
+ if $use_gdb_stub {
+ return 0
+ }
+
if ![runto_main] then {
fail "Can't run to main"
return 0
--
2.8.0
next prev parent reply other threads:[~2016-04-06 3:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 3:15 [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Simon Marchi
2016-04-06 3:15 ` [PATCH 2/4] Fix annota-input-while-running.exp remote check Simon Marchi
2016-04-11 18:03 ` Pedro Alves
2016-05-02 17:07 ` Simon Marchi
2016-04-06 3:15 ` Simon Marchi [this message]
2016-04-11 18:27 ` [PATCH 4/4] Fix solib-display.exp " Pedro Alves
2016-04-11 19:26 ` Simon Marchi
2016-04-11 21:32 ` Pedro Alves
2016-04-11 21:38 ` Pedro Alves
2016-05-02 18:20 ` Simon Marchi
2016-05-02 18:28 ` Pedro Alves
2016-05-02 19:52 ` Simon Marchi
2016-05-03 23:19 ` Pedro Alves
2016-04-06 3:15 ` [PATCH 3/4] Fix detach.exp " Simon Marchi
2016-04-11 18:16 ` Pedro Alves
2016-05-02 17:11 ` Simon Marchi
2016-04-11 18:40 ` [PATCH 1/4] native-gdbserver: Clear isremote flag in board info Pedro Alves
2016-04-11 19:14 ` Simon Marchi
2016-04-11 21:29 ` Pedro Alves
2016-04-11 23:14 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459912543-15328-4-git-send-email-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).