From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id E7ACB38582B8 for ; Thu, 21 Jul 2022 17:41:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7ACB38582B8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id z13so3259527wro.13 for ; Thu, 21 Jul 2022 10:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GcwyhN1QEhrs05VAo0/nluY3+IOTQ1J2y6JcHFv1Ti4=; b=d8r0EslbWJDm3pIP+AF9+KdBRHgP8LigzguEneYhUeguSJ9i0cGxiFk4CsH3urEs1S vIePxjah/7aH52UdzLVGF6c6iGZGDmRhWJikMo8Mb9a6yjZJKIZcDHerNOIN6TB6U3m2 gjYdubCv+4W6dOx99aD0vEAD6ak7gq1jkZPqmLvKcx4CjP3utrvnr1jWRCkIf25/hhUs 3aYZIODj7pObjzl4Ev5bJC6X463frGBIakTmn+d4CPzeQMXfFMENXxEXbr0P0+I12PaJ ra/+1yUvFTvGY8ToyF607nTFZ3vbjag2555PEyrcmYfCiJQNjKRE6vZR5apMhOY8YBuQ IGtA== X-Gm-Message-State: AJIora+SsBgem+bD65QKbC2waZ/VQt5EcntGOQFmwMw3rI92WVND1Pnt 7wmHxVbJEDUsEfSe1WFRfBSwTTTOyFo= X-Google-Smtp-Source: AGRyM1sI3gRWEJOqIzZQdgG1vjvmjK+eGWXTKU4AnWmgDq08uEOU9wi3dwNS4ePfgu9JYVgol9fSxQ== X-Received: by 2002:a5d:4b51:0:b0:21e:504a:b597 with SMTP id w17-20020a5d4b51000000b0021e504ab597mr5222367wrs.175.1658425301691; Thu, 21 Jul 2022 10:41:41 -0700 (PDT) Received: from ?IPv6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id x10-20020adfec0a000000b0021d6c7a9f50sm2617988wrn.41.2022.07.21.10.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 10:41:40 -0700 (PDT) Subject: Re: [PATCH] [PATCH] [gdb] adds several headers to the include list To: Christopher Di Bella , Simon Marchi Cc: manojgupta@google.com, gdb-patches@sourceware.org References: <20220720060120.1250880-1-cjdb@google.com> From: Pedro Alves Message-ID: <145f7f34-6558-bd0d-7e74-a7183332c196@palves.net> Date: Thu, 21 Jul 2022 18:41:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 17:41:45 -0000 > diff --git a/gdb/value.c b/gdb/value.c > index 022fca91a42..c9bec678d95 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -40,6 +40,9 @@ > #include "cp-abi.h" > #include "user-regs.h" > #include > +#include > +#include > +#include It seems to me that should have beeen included in the header (value.h): $ grep std::vector value.h std::vector *val_chain, extern std::vector value_release_to_mark