From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic313-21.consmr.mail.ir2.yahoo.com (sonic313-21.consmr.mail.ir2.yahoo.com [77.238.179.188]) by sourceware.org (Postfix) with ESMTPS id C7E3F3858C35 for ; Mon, 18 Dec 2023 17:32:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7E3F3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7E3F3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.179.188 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702920746; cv=none; b=sJRGqmAbTjC6OT1/EbGPkeYXC4pdNcbRvFmB0T2GGFPoHLykC1q7VyI6DLjVuvUY1o6BpdVEZsc9GE+OwsYS2r38eAyUkp9qbyDffc24sjdFdFetrnLaDvu0QZyFYpIKOIQShXrvYdQL/pK+KJykt1nV9bNN8ktNdBdgdrauAu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702920746; c=relaxed/simple; bh=nVMwf8R6VxXoiElLsNO7zfYIofuv97ac6vi/xuHK3lk=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=BvWzpmBXDF96jtInVyawBbGND+9BvO1WBuQpyb0ATwRy1gmvyyjHUDZiaYZ/zaTAwsymfatWur0req8DpznpdsaG+C6sX/wBoXdW52bYGX1JmbfHdL5RLJzqc7kvqYetzD4tek8ou3KB8Hi+8pkkZuLan+90UCcNCDz4dPVS4Kg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1702920743; bh=nVMwf8R6VxXoiElLsNO7zfYIofuv97ac6vi/xuHK3lk=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=CoTyRD9Ba3YxDXEMKBgQoD/w0zUlBegyekp8ZA7Z9ZiQrsE4x0/PA0UN0qLdAD5a4VZ1ATLsrLy1ZBgXj/UOTOwe/yIpcEABFgVBArsqAVw4jQicrTeQj2WZgY+mFpSutl5gAg1kya7Z+XMfWpY7nOnlevpp2/pX3HE9KTBFixzkx3QmbEiZaF5AC6JZ90mN3a0pPE6aqnEzK1BGl+wWdyBOP7KRLii9061MoEvxbjoTvEhns+NEhS53jCEMfN+Zf2sIXKW9HbSIwQnEdCkadseMdS/tk+4gURzH9TOhPL0rlNgyidnVej6rnB176oeN0l4o+jY/ajCX5wpOvo7IeA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1702920743; bh=uw9CWVWBiHWj9ESJdUusrcqdtlZP59L+fLIhxgsSZUk=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=UIRjJeG1XFOU46NTN62QOgFynd+fwI0OlokcJBVXxZ9zIcif2oIgl1lOrSMREKVw4ACpfRoq0xWhWE+ein1rDxVCUol/EoPcX/cA2C/CIObcGKPoNY0q75Au4TPvVs6b414ZiiABiu83sM2+w4uBcCQZLcg6qBUfG7elw5WqMwopawfPGEZFiHnT+/OQotZPdV0i8RSezGT31f0VPYD5nC2rMwgFMg/lEREzGNDhJ/fOErQR/HAi2OG4IFruAUym4gWw5PSPJgmVzWU1x5MhuJXXuqiy5VncUAN1/cWhz8utSrN4ArnhkXcDfM8+1umsUZODeCfgFtD5EUhPv2OPGg== X-YMail-OSG: u_H5xv4VM1kLzrt5mL5nJd6AveV4b4KYRXF95mrtSo4d9WSQPvzwdQezzyl90hP PUyQufEoLpWDcQldRWliVOjSuoXv.fRSYMnIw5HIjSMC1qzNnqxLCi1lHrRLekxjr46_N.AyqEJh XYQoHMtzTJMk0zl0btCFWVFSr0uwAXPYi9m0iiFWweOnJFASDgcmPGsMFGsBeq3SxrzTzozUOHLs 8L1gD5mRWxglKqwJuzTEk0pUSppFq0eBttet4EKJNchPXGfcUfnloMN6HAcEuz7FwupDEY4P_GOs Y9fDC9Jgu2BFA6jng.WUMS5UU1w61m99FHWxpTHk.7PUwclQMLU0EUBrSvogHxhDswGSmZWyj1OH qe6BFLhXNaoDaK_omyUDuMnCtFKKKSUmsdiHOhZ2vUUmK7xAYCLHBwULB6zRQljAH_WIURUo.xZj .1HqPh2q0mY9mQaSExjM7Owg49TWwTYsThkc3F_BkA5YATMWxYNEEHkmpcZrosTNlp4_UWQYbDHL 4.nsRzLop1SefE3DwMLmYTwvSDbDonhghiLLGYJdTf7m57JrUyG9PLJNnYK3Qc1dRjyoDPp1qZ_6 pwaAcPVKydJcq3wsVdvj5jmxJNUvbSVRN2X2zrfnXFH7tfy_.uhgK9m5xif9ve7MfGY4_CAiiMVU _3FwlmwA7ECZCKfRXXeyu80arcj_54TtrfTXJAqphHYnzuDBZvSgcCvAB_6e_C6UDB.v6FiTgMbz zIK6.m9vswptP.gB03hlTSNTFVELlknI44CD7Hq.Z9hYHb5YBuAAzcRyflafIJRJGoLsCXiFu_4x S9hB8bPFln33V7Q29VI1c_eQZJXNGA84eE6y4nlukLOcPUuBeIN_lCX9.ePDPOYso1l1vd0yo6Iy 35zH84krJxghZfdXl69jZicJ7ycfG4EDmbhwrX9_XSLl5E39h1.jVe2H2shcsDvG37ixUBheCax2 FPC3kFJcJyMnpwrEL5xaIiiMcEpSOMeutKSzu8bE69GOZ11N2UcOUTeJkhNC0JQMhS0.q7OC.mVU UJ8zhFHsCMbG362hlliGuJFaXUT_odxsnGMTlhSTD3mLMRIBDpTp.Pg1KHmLgq99Ah2HdK.FPmuW i1kkkWYXljVI0lSEiIxCDX_gvlTwpq6UwKr5J1GTE0BFb1qHyEkLOJLQyZ00z5bULo4J7fWOhy1v uK45au6zRwlkGoVYshYukJWVMTobsarhqYEIP38GQCQsAKuoVJ_hJ75Sz41AnqHlehKRcbRGvtgu XrJKear2fn1kWrZObLa.GZj8T2ExVS0f4G9k3ZqPsK608Os6CDiTVv36OSHQI2.62FcxwksK5lf8 EooDeZQgwISd_RhZYRQxbQb.eC7yfpeiZGgsYZeL3n7VhbZyNBgippUkEaamCnPz3tThvunLiCrA kX3isc5Aji6nfB5VTG6MrXgiGr.MIyqKCysUXxmCr9oYNZE0dUqZTJWv97ZlhmnosiEw_c8o3LLC swbtrdkLtwxw5Ir1mTnRin8OEQSCVoU_FItb.._lNPc9lUpI1tVXgoNMnwJjuoz1vcUxiXYIUB7e czpw8UZgUd6fKBQbTkAU42m2TkZDTQMLZV1vw_uocoo_WyWSCr6I30XuRtCrN37aaGv5N6HTvIrF kTkEMcI_wgePbQ52XK0WAE9NzkGhqgrsDGpuxEvcH4V2J7kH4HqqptOfE6W1dq2P31v3aDEoq.dF mIhfQhlN3Ibtzeyf83B5uUlv7xHgwx_3Ez9uHoM_xF40Fq2ITV3Ww9shrPquAjo5VuSbRw4XtWlz 7TaqDPfW22GgAKPXxUan8amcRQ7vVEIY8jJS2Eoamdph4HRbmzBC5lRSNo1MpEq631fMNi6aQ7L9 cpcXvZxyMEQlDq2h8ef34W42w1NxJW2.U7crUKzw2FB_ZmF_ZbbMRyrQnFSYd0BERd4MVgG1rGui Qgl9tLABv6ZdcupAuqda_xHjr6al8F9z0aZ15lMDkF8lbiq3idcwr5HncY0q8G8cLosRalFoh1lO EtiN5r23rABfduOGYmOy5TKFDKLq764SWuMqundy5H5RZ5LY.399463N0_ck7CUFpOkoyUt3bAbD O1CdQPIeOFqkCQ44BujFVm_dXyRUO1wtBdky5axztuRYxFDcuYK6jaNcIqOckgoQT2tKqLHxCFEf tuY6fTa1gmFYCbie6S_PYzXiIizTd02lq3zRWRinOEtvp9MZEOw7PqihmBExDNwm2hzRydOh7VWr Nolgf5NbjB7BVdMZEzX2TeUbqGgf1F.D5tH5TYCSWCo2k0Mw- X-Sonic-MF: X-Sonic-ID: 12f5cb56-153d-4538-925d-9b2aa57b2c73 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Mon, 18 Dec 2023 17:32:23 +0000 Date: Mon, 18 Dec 2023 17:32:21 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , Tom Tromey Message-ID: <1463654062.4443004.1702920741907@mail.yahoo.com> In-Reply-To: <20231217-tui-regs-cleanup-v1-11-67bd0ea1e8be@tromey.com> References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> <20231217-tui-regs-cleanup-v1-11-67bd0ea1e8be@tromey.com> Subject: Re: [PATCH 11/14] Remove redundant check from tui_refresh_frame_and_register_information MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21952 YMailNorrin X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Sonntag, 17. Dezember 2023, 20:51:57 MEZ hat Tom Tromey Folgendes geschrieben: > tui_refresh_frame_and_register_information checks 'from_stack' in a > block that's already guarded by a 'from_stack' check.=C2=A0 This patch > removes the redundant check. > --- > gdb/tui/tui-hooks.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c > index e47607fefa9..f1e4978a40a 100644 > --- a/gdb/tui/tui-hooks.c > +++ b/gdb/tui/tui-hooks.c > @@ -132,11 +132,10 @@ tui_refresh_frame_and_register_information () > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Display the frame position (even i= f there is no symbols or >=C2=A0=C2=A0=C2=A0=C2=A0 the PC is not known).=C2=A0 */ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool frame_info_changed_p =3D tui_show_fr= ame_info (fi); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tui_show_frame_info (fi); > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Refresh the register window if it'= s visible.=C2=A0 */ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (tui_is_window_visible (DATA_WIN) > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && (frame_info_changed_p || from_stack)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (tui_is_window_visible (DATA_WIN)) > =C2=A0=C2=A0=C2=A0 =C2=A0TUI_DATA_WIN->check_register_values (fi); >=C2=A0=C2=A0=C2=A0=C2=A0 } >=C2=A0=C2=A0 else if (!from_stack) > > -- > 2.43.0 Was the return value of tui_show_frame_info(fi) also useless? Regards Hannes