From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH] gdb: Use UNSUPPORTED not FAIL for unsupported target features
Date: Wed, 08 Jun 2016 09:26:00 -0000 [thread overview]
Message-ID: <1465377976-21678-1-git-send-email-andrew.burgess@embecosm.com> (raw)
If a target does not support making function calls from GDB then we
abandon the gdb.base/callfuncs.exp test file early. Currently we report
a single FAIL before leaving the test file, this commit changes this to
a single UNSUPPORTED.
gdb/testsuite/ChangeLog:
* gdb.base/callfuncs.exp: Report unsupported rather than fail for
unsupported target features.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.base/callfuncs.exp | 3 +--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 98a798b..9a08c73 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-06-08 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * gdb.base/callfuncs.exp: Report unsupported rather than fail for
+ unsupported target features.
+
2016-06-06 Simon Marchi <simon.marchi@ericsson.com>
* gdb.mi/mi-record-changed.exp: Adjust =record-started output
diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp
index fbe896c..1ec33d8 100644
--- a/gdb/testsuite/gdb.base/callfuncs.exp
+++ b/gdb/testsuite/gdb.base/callfuncs.exp
@@ -26,8 +26,7 @@ if [support_complex_tests] {
# Some targets can't do function calls, so don't even bother with this
# test.
if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
+ unsupported "This target can not call functions"
continue
}
--
2.5.1
next reply other threads:[~2016-06-08 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 9:26 Andrew Burgess [this message]
2016-06-08 10:25 ` Yao Qi
2016-06-08 11:40 ` Andrew Burgess
2016-06-08 14:59 ` Yao Qi
2016-06-13 14:29 ` [PUSHED] " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465377976-21678-1-git-send-email-andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).