public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Christoph Weinmann <christoph.t.weinmann@intel.com>
To: qiyaoltc@gmail.com, gdb-patches@sourceware.org
Cc: jan.kratochvil@redhat.com
Subject: [PATCH] fortran: Print logical values as either .FALSE. or .TRUE.
Date: Wed, 13 Jul 2016 07:56:00 -0000	[thread overview]
Message-ID: <1468396596-19212-1-git-send-email-christoph.t.weinmann@intel.com> (raw)

A Logical value in Fortran may be either .FALSE. or .TRUE.
When converting from integer, a subset of compilers evaluate
the whole value, while others only check if the least significant
bit is set.  This patch unifies the printing output by evaluating
only the lsb.

2014-03-25  Christoph Weinmann  <christoph.t.weinmann@intel.com>

	* f-valprint.c (f_val_print): Print .FALSE. when the lsb
	is '0'.  Print .TRUE. in all other cases.


Signed-off-by: Christoph Weinmann <christoph.t.weinmann@intel.com>
---
 gdb/f-valprint.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c
index b6d1ab9..06154d1 100644
--- a/gdb/f-valprint.c
+++ b/gdb/f-valprint.c
@@ -350,6 +350,20 @@ f_val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset,
       fprintf_filtered (stream, " )");
       break;     
 
+    case TYPE_CODE_BOOL:
+      {
+	int val = unpack_long (type, valaddr + embedded_offset);
+	/* As a superset of compilers treat logical values
+	  differently (e.g. .TRUE. can be "-1" or "1", the
+	  common baseline is to evaluate if the least
+	  significant bit is set or not.  */
+	if ((val & 1) == 0)
+	  fputs_filtered (f_decorations.false_name, stream);
+	else
+	  fputs_filtered (f_decorations.true_name, stream);
+      }
+      break;
+
     case TYPE_CODE_REF:
     case TYPE_CODE_FUNC:
     case TYPE_CODE_FLAGS:
@@ -359,7 +373,6 @@ f_val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset,
     case TYPE_CODE_RANGE:
     case TYPE_CODE_UNDEF:
     case TYPE_CODE_COMPLEX:
-    case TYPE_CODE_BOOL:
     case TYPE_CODE_CHAR:
     default:
       generic_val_print (type, valaddr, embedded_offset, address,
-- 
1.7.0.7

             reply	other threads:[~2016-07-13  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  7:56 Christoph Weinmann [this message]
2016-07-13  8:03 ` Jan Kratochvil
2016-07-13 13:32   ` Weinmann, Christoph T
2016-07-13 13:54     ` Jan Kratochvil
2016-07-13 10:17 ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468396596-19212-1-git-send-email-christoph.t.weinmann@intel.com \
    --to=christoph.t.weinmann@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).