From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>
Subject: [PATCH 0/2] Consolidate target_{wait,resume} calls between GDB and gdbserver
Date: Mon, 29 Aug 2016 04:12:00 -0000 [thread overview]
Message-ID: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> (raw)
Hi,
This simple patch series proposes a consolidation of the calls to
target_{wait,resume} functions between GDB and gdbserver. This is a
necessary and helpful step in the direction that we're heading, and is
particularly important for my work on the unification of fork_inferior.
The first patch implements a new function, target_continue, on top of
target_resume (or the_target->resume, depending on where you're
looking), and replaces all calls to target_resume (or
the_target->resume) by either target_continue or
target_continue_no_signal (this last one has been a GDB citizen for
some time). Note that I haven't touched infrun.c's
"do_target_resume", which is a wrapper around target_resume and does
many other things.
The second patch, which is even simpler, is meant to pay a technical
debt on gdbserver: the lack of the "target_wait" function. So there
it is now, properly implemented, even though everyone else will still
use mywait because it accounts for many aspects that the regular
target_wait doesn't. This is actually another place for future
improvement: make the two versions of target_wait identical API-wise,
so that sharing code is easier.
Both patches do not introduce regressions (I've tested them using the
Try server feature on BuildBot, BTW).
OK to apply?
Thanks,
next reply other threads:[~2016-08-29 4:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 4:12 Sergio Durigan Junior [this message]
2016-08-29 4:12 ` [PATCH 2/2] Share target_wait prototype " Sergio Durigan Junior
2016-08-31 10:29 ` Pedro Alves
2016-08-31 10:30 ` Pedro Alves
2016-09-01 18:58 ` Sergio Durigan Junior
2016-08-29 4:12 ` [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume Sergio Durigan Junior
2016-08-31 10:25 ` Pedro Alves
2016-09-01 18:57 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472443911-29056-1-git-send-email-sergiodj@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).