From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2356 invoked by alias); 29 Aug 2016 04:12:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2323 invoked by uid 89); 29 Aug 2016 04:12:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1375, heading, proposes, debt X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Aug 2016 04:12:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C89661E46 for ; Mon, 29 Aug 2016 04:12:00 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7T4BxH8017393; Mon, 29 Aug 2016 00:12:00 -0400 From: Sergio Durigan Junior To: GDB Patches Cc: Sergio Durigan Junior Subject: [PATCH 0/2] Consolidate target_{wait,resume} calls between GDB and gdbserver Date: Mon, 29 Aug 2016 04:12:00 -0000 Message-Id: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00286.txt.bz2 Hi, This simple patch series proposes a consolidation of the calls to target_{wait,resume} functions between GDB and gdbserver. This is a necessary and helpful step in the direction that we're heading, and is particularly important for my work on the unification of fork_inferior. The first patch implements a new function, target_continue, on top of target_resume (or the_target->resume, depending on where you're looking), and replaces all calls to target_resume (or the_target->resume) by either target_continue or target_continue_no_signal (this last one has been a GDB citizen for some time). Note that I haven't touched infrun.c's "do_target_resume", which is a wrapper around target_resume and does many other things. The second patch, which is even simpler, is meant to pay a technical debt on gdbserver: the lack of the "target_wait" function. So there it is now, properly implemented, even though everyone else will still use mywait because it accounts for many aspects that the regular target_wait doesn't. This is actually another place for future improvement: make the two versions of target_wait identical API-wise, so that sharing code is easier. Both patches do not introduce regressions (I've tested them using the Try server feature on BuildBot, BTW). OK to apply? Thanks,