From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1190 invoked by alias); 13 Sep 2016 17:10:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1171 invoked by uid 89); 13 Sep 2016 17:10:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*MI:121, H*m:121, screw, realized X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Sep 2016 17:09:56 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8DH8v5p090827 for ; Tue, 13 Sep 2016 13:09:55 -0400 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0b-001b2d01.pphosted.com with ESMTP id 25e3x1ysqn-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 13 Sep 2016 13:09:54 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Sep 2016 11:09:52 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 13 Sep 2016 11:09:51 -0600 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: cel@us.ibm.com Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 76B033E40048 for ; Tue, 13 Sep 2016 11:09:50 -0600 (MDT) Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8DH9Qx314483958; Tue, 13 Sep 2016 10:09:49 -0700 Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 41E3478056; Tue, 13 Sep 2016 11:09:49 -0600 (MDT) Received: from [9.70.82.29] (unknown [9.70.82.29]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id D0A5C78038; Tue, 13 Sep 2016 11:09:48 -0600 (MDT) Subject: Re: [PATCH] Fix for gdb.server/non-existing-program.exp test case From: "Carl E. Love" To: Ulrich Weigand Cc: Andreas Arnez , gdb-patches@sourceware.org, Edjunior Barbosa Machado , Ulrich Weigand Date: Tue, 13 Sep 2016 17:10:00 -0000 In-Reply-To: <20160913153701.960F411C2B7@oc8523832656.ibm.com> References: <20160913153701.960F411C2B7@oc8523832656.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16091317-0028-0000-0000-000005928659 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005755; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000185; SDB=6.00757307; UDB=6.00359093; IPR=6.00530685; BA=6.00004717; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012661; XFM=3.00000011; UTC=2016-09-13 17:09:52 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16091317-0029-0000-0000-00002F2EB9D4 Message-Id: <1473786588.4102.121.camel@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-13_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609130244 X-SW-Source: 2016-09/txt/msg00098.txt.bz2 On Tue, 2016-09-13 at 17:37 +0200, Ulrich Weigand wrote: > Carl Love wrote: > > > I fixed up the comment per your suggestion. Not sure what happened with > > the formatting. See if this looks better. > > > + /* The last_status.kind was set by the call to ptrace(PTRACE_TRACEME, ...). > > + The function linux_wait() has also been called. At this point, the > > + target process, if it exits, is stopped. Do not call the function > > + target_post_create_inferior if the process has already exited, as the > > + target implementation of the routine may rely on the process being live. > > + */ > > Formatting looks OK now, except that the trailing */ should not be on a > separate line; see other multi-line comments how those should look like. > > However, the comment still mentions ptrace and linux_wait, which is also > only true on Linux targets. I'd just leave that off. > > Patch is OK with that change. > > Bye, > Ulrich > Patch committed. Note, I updated the comment per requested. Note, I realized I only did part of the requested update initially and then did then removed the ptrace () comment. The patch didn't get updated with the removal of the ptrace () comment. I had to do a second commit to get the ptrace () comment fixed correctly. Sorry for the screw up. Here are the two commits. https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1d8cb77dff14d44b1e3b670442438da496f99c6e https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=7313bced5b695b71a707c82b6817763046e21bb1 Carl Love