From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112497 invoked by alias); 25 Nov 2018 19:56:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112475 invoked by uid 89); 25 Nov 2018 19:56:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*u:1.3.6, H*UA:1.3.6, Hx-languages-length:585 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Nov 2018 19:56:41 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id wAPJuYDg007682 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 25 Nov 2018 14:56:39 -0500 Received: by simark.ca (Postfix, from userid 112) id BB31A1E992; Sun, 25 Nov 2018 14:56:34 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id B1AEF1E473; Sun, 25 Nov 2018 14:56:32 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 25 Nov 2018 19:56:00 -0000 From: Simon Marchi To: Sergio Durigan Junior Cc: Simon Marchi , GDB Patches , Alan Hayward , nd Subject: Re: [PATCH v2] Implement timestamp'ed output on "make check" In-Reply-To: <87wop13z2z.fsf@redhat.com> References: <20181122221240.15354-1-sergiodj@redhat.com> <20181123150256.22584-1-sergiodj@redhat.com> <61b6c448-bae1-2dd9-87a7-5c500be0aa09@ericsson.com> <87wop13z2z.fsf@redhat.com> Message-ID: <147c28c03427ad7e1e6a9dfd976b027a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00426.txt.bz2 On 2018-11-25 11:24, Sergio Durigan Junior wrote: >> As for the coding style, according to the wiki [1], we should follow >> PEP8 (which >> I think makes sense). Can you change your script to folow that? >> "autopep8 -i print-ts.py" should do it. > > Hm, the command doesn't output anything to me, and $? = 0. Is there > anything in particular that you noticed? The command modifies the file in-place, so you should have unstaged changes after running it. In particular, it should remove spaces before parentheses. Simon