From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49946 invoked by alias); 25 Jan 2017 08:38:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49924 invoked by uid 89); 25 Jan 2017 08:38:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*MI:sk:1484560, memory_error, read_memory, MEMORY_ERROR X-HELO: mail-pg0-f65.google.com Received: from mail-pg0-f65.google.com (HELO mail-pg0-f65.google.com) (74.125.83.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 08:38:28 +0000 Received: by mail-pg0-f65.google.com with SMTP id 3so1338767pgj.1 for ; Wed, 25 Jan 2017 00:38:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=xeyu1V5xTyb6QPz5eTHBDq+TGJjMoyFnLQBVCd9dxHI=; b=nIHXsF0wlXhlRCYXZ4uS5JiDqfWf8HhhraqNcQUPum3xHpRAiXkDSnXsuo36QZYkM3 j7ovOC89V57XfA/V7wP4PFiKz143PV/8Mts92Dl+j5TJ/8MbYQV9OW6U7XCwHwQsu+kP MZveN/U/VyCVdZRIa5qADOEbGT3VATodwj9LYmZ8e96SELMi+GTmr/+AaFoHsePM8WiC NtfGTpRvoGm7d4ek4zUk4DKglsapBfBVaetf30p7Y1uI4tf5rT36cvJ06KTUTg1r+V5Y P433K93wSHdxgpF0Kj/xXGgbZpnhOkmkLUX9MfWUywoO0yASgpncih+y8+TJP+Gth3jr GWyA== X-Gm-Message-State: AIkVDXJS7lhRXb6KahMVNesW7th6doeBDD+Q+imiTq6+4BaGUvtb3GulOEcQguz0WGxrsA== X-Received: by 10.99.159.2 with SMTP id g2mr17003638pge.178.1485333506921; Wed, 25 Jan 2017 00:38:26 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id x2sm50271378pfa.71.2017.01.25.00.38.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Jan 2017 00:38:26 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 5/6] Disassembly unit test: memory error Date: Wed, 25 Jan 2017 08:38:00 -0000 Message-Id: <1485333480-20515-6-git-send-email-yao.qi@linaro.org> In-Reply-To: <1485333480-20515-1-git-send-email-yao.qi@linaro.org> References: <1484560977-8693-1-git-send-email-yao.qi@linaro.org> <1485333480-20515-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00514.txt.bz2 This patch adds a unit test about memory error occurs on reading memory, and check MEMORY_ERROR exception is always thrown. v3: - shorten the function name, - see_memory_error -> saw_memory_error, v2: - use null_stream, gdb: 2017-01-24 Yao Qi * disasm-selftests.c (memory_error_test): New function. (_initialize_disasm_test): Register memory_error_test. --- gdb/disasm-selftests.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/gdb/disasm-selftests.c b/gdb/disasm-selftests.c index 3d68abd..c89c5ed 100644 --- a/gdb/disasm-selftests.c +++ b/gdb/disasm-selftests.c @@ -164,6 +164,47 @@ print_one_insn_test (struct gdbarch *gdbarch) SELF_CHECK (di.print_insn (0) == len); } +/* Test disassembly on memory error. */ + +static void +memory_error_test (struct gdbarch *gdbarch) +{ + class gdb_disassembler_test : public gdb_disassembler + { + public: + gdb_disassembler_test (struct gdbarch *gdbarch) + : gdb_disassembler (gdbarch, null_stream (), + gdb_disassembler_test::read_memory) + { + } + + static int read_memory (bfd_vma memaddr, gdb_byte *myaddr, + unsigned int len, + struct disassemble_info *info) + { + /* Always return an error. */ + return -1; + } + }; + + gdb_disassembler_test di (gdbarch); + bool saw_memory_error = false; + + TRY + { + di.print_insn (0); + } + CATCH (ex, RETURN_MASK_ERROR) + { + if (ex.error == MEMORY_ERROR) + saw_memory_error = true; + } + END_CATCH + + /* Expect MEMORY_ERROR. */ + SELF_CHECK (saw_memory_error); +} + } // namespace selftests #endif /* GDB_SELF_TEST */ @@ -175,5 +216,6 @@ _initialize_disasm_selftests (void) { #if GDB_SELF_TEST register_self_test_foreach_arch (selftests::print_one_insn_test); + register_self_test_foreach_arch (selftests::memory_error_test); #endif } -- 1.9.1