From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic313-20.consmr.mail.ir2.yahoo.com (sonic313-20.consmr.mail.ir2.yahoo.com [77.238.179.187]) by sourceware.org (Postfix) with ESMTPS id 2B3BA3858D37 for ; Sun, 17 Mar 2024 14:12:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B3BA3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2B3BA3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.179.187 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710684771; cv=none; b=OwbUZha8kkWR76O4oesUKDiSiJCfKMDuFxtf/A5zcJMOL4p4RhmwW4np+NtwuyzZdeeyerXYiPJSISEbeBp6Yu/SuNXcksD8/L6/886h15duV1jSZV5ecseNHAU55wFUwFPc7bclmn9GNXqwEuzutABGXbTpuBN/JS3D8BsLks8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710684771; c=relaxed/simple; bh=9nTlhRKR+GjVrjqZ5JFaRUhS8d0sh1aAAD4vZF26pyY=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=qSIRSTgvF2vSVPXc0LeszqbzsOaux/sU55yVwbvk2vsj0Oz8JeqibOR/2rQzan7PXFFSs15PfHf5Evsooat8npCYKk/G2mSey7kisCuOSdpKPf8bLXhEJgVSxqqBp7t/0OFxKEDnmABqbr4iL2eTPtO6L+KBYGA69fQmREXMS5g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1710684767; bh=9nTlhRKR+GjVrjqZ5JFaRUhS8d0sh1aAAD4vZF26pyY=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=PgRTK9BXd9B57glmhDIjAKXRb58oaJ8aJkNYii4z7tmV2QAajiEksakzmjYg/qQpW1he02g9/Odgl62tS4EpIKOUsjT/pDoMJfTc84FhajawwDodVbw96/rVVPswqEiPiC7a5l2sRbdecv4T6MxZa+RQ6O56acBeNbfdrDKQPU/tYKSG3OzjLZMmJEMmaoMSkbk7bRfT76E84n8f5HC8wW3gBAkE9G8iIJSR+KDf9wZVSGGkBWyTfvZ7fj6Xqt+Lln9E2BuWo0LcLv+ETx3RIY0w6v74jPGaEn/vMiAxoR8GY92TyGN03qEmPckYmUbUgOs2nwt0Hr87DG/h6S0nIQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1710684767; bh=3q+H0mVESiVWXcb8hRWkipj2xJpmyCRpPcy7Gvw33JG=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=mJZFlNWTi0EqZXpVtQABM4gKwH7KGP89f8hBfxhxsiE3eDEU0omunSNI7sO0BsD1OzxOf8rNYdF0HXUl2VcI3PVzGUromhEFuUYp1D3fM+RK9H0r44Ec6DX+ySwqVdwXWcWGID3tJSTjZpzap4knHmCwR9f7UWg62Z9eoOfbtUMtelMG7c03pvLFvNvZqV91NrUwx1RZ5JjMqlBGr9rmW7nNpz+OlSCFGZqhLH5JHmm/oPAEThYesGAq+Fw4SzkNSSgVah1aYEfc0sG0Dqtd2mv3UPUMgavOTmBMTGj0AHg9ZpQ62xaFbkX/U4spmpZIb3U22/dzKIongWmOVdxiDQ== X-YMail-OSG: 0xegbp4VM1mlPZZd5Byybd_yPYSAZVUHCrC1VYBzWSGViiYHHoxG7jYIkkxiQ3i Cxl43VzhKjSBgKKPA8bVgG908lwVRRQynlT8RQezX3bxXJ1nTcIhFe5y5lA1s2LamC_9UhJSK1ig pO.A4aiPOOk4anr_dxEzmwUbeYwax.UhjySxiW7p1.y.f2FvC5pWXA79HfNue9YdgwcNy4XpB9hh C7rTxsNu7dVlROj2VO2mk08bDG2vbR6CAPN9dMW0TSctygvA0O23Lu.YYOWK0e6QNuel5QLD4fkX jv_1Y.a6UIzKOBdSFyXYsKup8b3WJIjZ8g7DWyqwM2_AT_1hz3XuN_ooF.KmxRnFkq9hyd1ZOp22 qGPDxhcQqDqi0O1MI77EjwHJgNmoauqVgVS.oa3GceDtTCiXkrnsMO5jp0hjM3dZTd4RqKhBDqc9 lo2OAbwZ2bhWUMGOAWHNp_ejGYTdhUrYVdsvnJszQ51nuMaMXdorbEjilB.QgIOammPjNm5xfQ4U KcL1IXbiMS_7fURdavXcExRAoLCMi92jIzlzWdZMaaJXWYoFpKhV4XwbnS4ApsUE_fSCdvVcFgya KBOZ74a3rHdXeomRP0cBMIrJNNowtKsEB.1NfAtNy3KADOhHCUBbDy8iKi46Iamg1aLuvJmMQKx0 s9VsrF5p2Gx6Sg9d.mSLG8os.uxhSTYaUM7nuvXerzu_8ecvuR0nSst6_zlEW8xfzY2uuVozdnRo 3jyNdlslOuHsX.X9Jw9GcVQfdaOAvYuORR8j9IMRTDCRPvculqagCyDDedsPGiFgCsm358lK_kfp IHZBCiPE_JwPFFz.WUk03FnoWwPk_ml8l.TavEccw8c5A9sw8FlRNieUTNrw1PTzVc_1s6hF_Nop ml6QVzidgzdm9XU2Y2E7KFLttY8Rh.2IhIycfRUUs1iOw2JYSSnHKvRoRT1esU3J_FEc_6p0MQsO WS_WmrRtwf9ApeqdN4i4Rj3_a6fFn2wCS2pFNph209nV1x6MBOwZs42dQzlz7VSpGTn6dtWpFFOm rVrWuaRfJr2JjIg5k87WlacHN.bWDfvJpHxxQi4kx1ce.65V.XSyzKiqIWGSQCAn55b1Gh7JGghN 3pLjbIiRHPyYQVeXtSKJT4R521tTXQ10XP4Sm6RdgrZr4oD0UZAbAnD1ERNrwODR1j_e5caLz7_n ATxC6M3bwoi7Cu0euJah9spGariR9WCkPrzZTPbpEq_M_i3oMZehug1HkW_PMuO4z66MOSOqvczh KzqBE0OMjDJToH_tOqIJt_yDTxEQn8pgoTQCgO0V9fUsXj_IKv2WIV9T8HV6OnkoFKjQ1FDULrEb WEJn7jbSnaQoU4n5CD1AqAAA30ohATwUpVzcvqBRLnMdqZJ6O_RAAo7el99_bkI9cAUD07viYtMB nDd.CJLbypRTake9cYSx4Sxe1oguieymzGFzZkYhZh3bmr9_Tm_1RoaCHaO_KoVHAhnu47VW9Kzt I2HtlzgnOHuHZ11h677xpREaVsGBzIXKqS7pHnbMI71n8m5icBMXfwH7B4x4LpIDZcYIe3BXp3b_ TWWSpjqTTYaXyUe_hLBhvEuIMxJ2QVJQuSpWCFAvG4TE_Ai.af.MwbzvjJfO8VN5DMBP9onSbFV9 xIRdIlo.qYnvtM0UrQnsn8eO50T4I0tYDVZ2RMVxafuK3miYC3Ce1jXEWWxHNzaOt9pRVR9_QeOO .bBumcB24M_V.XEM73243nbIlS0yoaHHvMu_ckC2vYShcepW3ZQT.Y.gePhuSAsYdlubClKfKleS CQLCruJwIqTlkjVYR80ODN6AvHNMl05t8M.xhlDozw3LPVBCBj193bXmkT7jT5mW2IKIlRYO.ozu pCoaJd6tXD50DY7BWGIUuHJbsfCBfph.9Ppg0RKa4G.DvmvSgtom11sftX7U2mA4pILOyBYf03oC tAbnuf0HoZ49ndI50waUDqYNiSW9Uc0EsriKndRpi8Pl7amvkhzBdF7mofp9LuOudRoZgQfCXl9L .T5NERVvu_WyhRgMXjOzL0jfqiBjtWpzQsqxzsfTDcc2SLdGf7pGKG1R4nhG.nlYPw.5a2uopuMd MVWJa6MTsgxxWWPSfy3GTE.0qk4aK618GyN3G3vX4BCajMPl96zsxplJTMZTrz.khKsv0RSjKCGy I3FSSO17IFhd8ICg3Q8ZMl7m7v8yJO5AsuhTDEWFJGQxP44jQSMniXGC6mh1faEnI5C6Top8KsRf OIzh12cQyBlZRVlEIAFP2xNOksaNp1_9vjVkjg7euQu_x7wv6 X-Sonic-MF: X-Sonic-ID: 08206f12-81bf-4490-87a6-bb23ca00b79f Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Sun, 17 Mar 2024 14:12:47 +0000 Date: Sun, 17 Mar 2024 14:12:45 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , Guinevere Larsen Cc: Keith Seitz Message-ID: <1491730163.8675235.1710684765346@mail.yahoo.com> In-Reply-To: <4b9a274e-f072-4408-b797-857573a96b11@redhat.com> References: <20240209194545.31497-1-ssbssa.ref@yahoo.de> <20240209194545.31497-1-ssbssa@yahoo.de> <4b9a274e-f072-4408-b797-857573a96b11@redhat.com> Subject: Re: [PATCH] Fix comparison of array types MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.22129 YMailNorrin X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Donnerstag, 29. Februar 2024 um 14:26:16 MEZ hat Guinevere Larsen Folgendes geschrieben: > On 09/02/2024 20:45, Hannes Domani wrote: > > Currently it's not possible to call functions if an argument is a > > pointer to an array: > > ``` > > (gdb) l f > > 1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int f (int (*x)[2]) > > 2=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > > 3=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return x[0][1]; > > 4=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > 5 > > 6=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int main() > > 7=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > > 8=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int a[2][2] =3D {{0, 1}, {2= , 3}}; > > 9=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return f (a); > > 10=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > (gdb) p f(a) > > Cannot resolve function f to any overloaded instance > > ``` > > > > This happens because types_equal doesn't handle array types, so the > > function is never even considered as a possibility. > > > > With array type handling added, by comparing element types and array > > bounds, the same works: > > ``` > > (gdb) p f(a) > > $1 =3D 1 > > ``` > > > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D15398 > > Co-Authored-By: Keith Seitz > > Hi! > > This patch fixes the problem (for both gcc and clang) and introduces no > regressions. > > My one nitpick is that I think this code fits more naturally right after > the pointer check, instead of the last check in the function, but feel > free to disagree. Either way: Reviewed-By: Guinevere Larsen > Either position is fine for me. Hannes