public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH 4/5] linux-low: Remove usage of "register" keyword
Date: Sat, 10 Jun 2017 19:58:00 -0000	[thread overview]
Message-ID: <1497124689-11842-5-git-send-email-simon.marchi@ericsson.com> (raw)
In-Reply-To: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com>

AFAIK, the register keyword is not relevant today, and clang complains
about it:

/home/emaisin/src/binutils-gdb/gdb/gdbserver/linux-low.c:5873:3: error: 'register' storage class specifier is deprecated and incompatible with C++1z
      [-Werror,-Wdeprecated-register]
  register PTRACE_XFER_TYPE *buffer;
  ^~~~~~~~~

I think we can safely remove it.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_read_memory, linux_write_memory): Remove
	usage of "register" keyword.
---
 gdb/gdbserver/linux-low.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 7fbf744..c8e8d08 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -5870,11 +5870,11 @@ static int
 linux_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len)
 {
   int pid = lwpid_of (current_thread);
-  register PTRACE_XFER_TYPE *buffer;
-  register CORE_ADDR addr;
-  register int count;
+  PTRACE_XFER_TYPE *buffer;
+  CORE_ADDR addr;
+  int count;
   char filename[64];
-  register int i;
+  int i;
   int ret;
   int fd;
 
@@ -5958,16 +5958,16 @@ linux_read_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len)
 static int
 linux_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr, int len)
 {
-  register int i;
+  int i;
   /* Round starting address down to longword boundary.  */
-  register CORE_ADDR addr = memaddr & -(CORE_ADDR) sizeof (PTRACE_XFER_TYPE);
+  CORE_ADDR addr = memaddr & -(CORE_ADDR) sizeof (PTRACE_XFER_TYPE);
   /* Round ending address up; get number of longwords that makes.  */
-  register int count
+  int count
     = (((memaddr + len) - addr) + sizeof (PTRACE_XFER_TYPE) - 1)
     / sizeof (PTRACE_XFER_TYPE);
 
   /* Allocate buffer of that many longwords.  */
-  register PTRACE_XFER_TYPE *buffer = XALLOCAVEC (PTRACE_XFER_TYPE, count);
+  PTRACE_XFER_TYPE *buffer = XALLOCAVEC (PTRACE_XFER_TYPE, count);
 
   int pid = lwpid_of (current_thread);
 
-- 
2.7.4

  reply	other threads:[~2017-06-10 19:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-10 19:58 [PATCH 0/5] Remove a few hurdles of compiling with clang Simon Marchi
2017-06-10 19:58 ` Simon Marchi [this message]
2017-06-10 19:58 ` [PATCH 2/5] gdb: Use -Werror when checking for (un)supported warning flags Simon Marchi
2017-06-10 19:58 ` [PATCH 3/5] gdb: Add -Wno-mismatched-tags Simon Marchi
2017-06-10 19:58 ` [PATCH 5/5] Add ATTRIBUTE_PRINTF to trace_start_error Simon Marchi
2017-06-14 19:49   ` Sergio Durigan Junior
2017-06-10 19:58 ` [PATCH 1/5] gdb: Pass -x c++ to the compiler Simon Marchi
2017-06-11  2:36 ` [PATCH 0/5] Remove a few hurdles of compiling with clang Eli Zaretskii
2017-06-12  7:56   ` Yao Qi
2017-06-12 14:36     ` Eli Zaretskii
2017-06-12 15:54       ` Simon Marchi
2017-06-12 16:23         ` Andrew Pinski
2017-06-12 16:35           ` Pedro Alves
2017-06-12 16:37             ` Andrew Pinski
2017-06-12 16:45               ` Pedro Alves
2017-06-12 16:55                 ` Pedro Alves
2017-06-12 16:44           ` Simon Marchi
2017-06-12 16:55             ` Andrew Pinski
2017-06-12 17:00               ` Simon Marchi
2017-06-12 16:44         ` Eli Zaretskii
2017-06-13  9:14           ` Yao Qi
2017-06-13 10:23             ` Simon Marchi
2017-06-13 11:06               ` Pedro Alves
2017-06-13 11:08                 ` Simon Marchi
2017-06-13 14:38               ` Eli Zaretskii
2017-06-13 17:07                 ` Simon Marchi
2017-06-13 19:23                   ` Eli Zaretskii
2017-06-13 20:17                     ` Simon Marchi
2017-06-14  2:29                       ` Eli Zaretskii
2017-06-14 10:45                         ` Pedro Alves
2017-06-16 16:12                           ` John Baldwin
2017-06-13 15:22               ` Yao Qi
2017-06-13 15:44                 ` Eli Zaretskii
2017-06-14  9:07                   ` Yao Qi
2017-06-19  8:07                 ` Yao Qi
2017-06-13 10:44             ` Pedro Alves
2017-06-13 15:09               ` Joel Brobecker
2017-06-17 21:23 ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497124689-11842-5-git-send-email-simon.marchi@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).