From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95773 invoked by alias); 21 Jun 2017 20:15:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95042 invoked by uid 89); 21 Jun 2017 20:15:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 20:15:32 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id A0.07.16346.AD3DA495; Wed, 21 Jun 2017 22:15:25 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 21 Jun 2017 22:15:22 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.localdomain (80.216.243.234) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.6; Wed, 21 Jun 2017 20:15:19 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 2/4] x86-dregs: Print debug registers one per line Date: Wed, 21 Jun 2017 20:15:00 -0000 Message-ID: <1498076108-29914-3-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: HE1PR0802CA0016.eurprd08.prod.outlook.com (2603:10a6:3:bd::26) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0497061f-c522-4a28-2503-08d4b8e23d2c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;3:m4YRIlN7FV3gQ1PGkUboNYRMMaIczwIndFqU/DDcekT2coFtR+D6ovOS9Zz6kbRQa5fEX7TOJeQahsgCugmVeMhtcXWZXgWNd62wFJoqWy50nB5DH9+tTq2PYKp9eUNFqBUdnPrwqa6QSep3dOYOMVupK9JbLe0jAN3vN37MXt64QELO8cCMDAxv21pkc4CAKhAentzeQ3BV1mJGJWrj3EoYu7prSiDEN3zjcLZHNKTuqGAdzjfWAOMh16r84Bq3lgrrWH/Tp0uKaC1e9b/fH1DACq8nJZF/ueFwQyFgj4gfYRXOeiai1k60CD8iL+0zV7m23SSvp6c77TBavN/p2Q==;25:hsFbb4Lkq/JqxiJDYAuY5DTh+QH2YR4AKaAA7Y3B2lpOBvYQ65qYhfrVtk7dXGkCHp7V16kDn7nK07Fj6MmqqZYxnQ7B2u85SC1S8l6y/x81oeUy5EbtSLdPiYXXyG6yK01IfBrWxfzE7U/Oy/HDj+hIAhj3B3sGrYNrvlpFXHBA6w23P29RjMzUzQKcPvJPR0hYDOmfhD0zGcdEIqeAbwQyXvwNfxmg/dl2EiuDLlHT6QX6DpdR8kwWXogJTC2dGpbdgjkFfOd6ERQHl6/5T/pc6x/VF82E6SDTb2UQTQzy+ByOAtPbgYordgUyckH6MqPAxQPM3QtB3RDzY7p7mydUt37BQkYoXFC5/YzL+1kWPgja+5xIEGKYAydSTyGsvihHDpww7wpF01tbMAAVUtL8Vv3uIyYKg/VG6trRqkP/nchhD3EFTqPAmbnR/myRVEDyL7WIRQWXJuUwXhwRufZ1cJzj14zHsDHP/P974tA= X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;31:7fzHJjbu+W7wk5+nyVeXvEfOqv0KEXpSmgTYNYgO6QEJ4iJkHpaMSquzvaGg03eXTku7+U2p3TIMluio8C4/0pcdPJZFmOoSNe/HM2uoHy/62Jzp0w7rDtSNiq77kUpzSeag1hJV/So5NooQFeA6sguyueyfTUNLx+S3YJ87FgYj067Zw/S1VAsCQsFu/FfMtiDNS5CWKb7iyjp0ujcEUMQiyQ/bn9bdGgF2dj9/gnc=;20:Gx5iTv7qbfJjVhWeSEzXmWNPU3o2/LpkIe1rJIlhWgHAJWd+DIuAGjP5fd19yHdexiZk2RIx5tovukOkXj5dkX4tk39p+osbJy20knUqtP9fbm87MzaPFKYhtS3UKVVbEmfnjOOqfjWTvb6yfLNHAsfs+hPzF9rWZMjdwFoaMNTxjqe0V7H5v1ukgGW7oA7JCKNpeFApoySiOUhBt8IneUeuzz2iqbHhqvOUXFlPd6njvKcx3/HvMGQ2l6C2Rb4z3rxkRBCe5gvyAiyH3seoetLsF3IpFDelrTZu/E/YKkHFD9bwtkA+6iC2nugV2CAWqzpvXDOKNQb7IwPcgCGA7buUUWuf2o84JAdOykBLRUTn4QQp4B20dHcmfjc98AR7Hqncu0WnXwKNEI7kZHc976t18bF4pm0TTNegAHmVe3qB6cIr2TcfVcfUOknhp3jPABW4zqS/wgEA74wvmU+P0YmipZIx5DEIZUxkguqUh/Ooy/KwOA9pInR0kSAG7qWQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB320;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB320;4:g06kv+d7e/ogJsHZKknxP2dD1LCO30/aif36meK4sj4?= =?us-ascii?Q?6CxwRufq27JJkjDoTunVFEgomRx5xI6sUkkayNOTqFuXdF4NQKZ2ASi6UN6B?= =?us-ascii?Q?qq3ZPgJZPNNbVtEbhmoqfF5Qoo97G53CmbBhB0L39qKqnSEDgeFIcB8LMMzr?= =?us-ascii?Q?ty1L7VoCrDKaSig59TCJXE8Y47pP1JM4eKqZXrvIFCQPh7DCtz3PB3hcg52Y?= =?us-ascii?Q?R2DUPIMcIQP7Nx3nVOId8H8JESuf0qacRZqGVwCTYfGBf7bOFliyns798EKl?= =?us-ascii?Q?xQVi7i+VXnaWNbX1qAidSpjGyIEuUzfCOIg4Yx3j/T9Ln6EVqZXDBnhXWaOg?= =?us-ascii?Q?vmq/mQk0N1gY7JUYgVQSP9Nhx0FJYxEGS6qflom9sZQ9DQ7Rbp1SwyHOS1sD?= =?us-ascii?Q?scOQzO9EN4ZtTSuCU0JFGelnEocDis3wfqRkdvWp/PkzC3cIUO13V1BXrpEI?= =?us-ascii?Q?S5ZR3nHxURGTDWJCkmvewaC2MGmDNomER5Jfk+Pfl5jTu/bH5qOdMAwxvhUq?= =?us-ascii?Q?lW4Zk3q2IRIl6iHbuYu/AINpvjcEBK0QIZYrCDWzJyRvcEW6Twq+JIvUqvDK?= =?us-ascii?Q?CZuVn8y+l8USipuOGaAjiqb4JY6vvJb6AEsnwoEioOqNRMFFobUUe/0826+X?= =?us-ascii?Q?3aBKm5f4trk6Fwkc/nUDvHyN7yqNEp9qtRBh5rzXehtqiVD2tv9kq0y6GpdZ?= =?us-ascii?Q?D2pWahTjJGLuyN7MnJDe/FI6pVKkWrHUuFibiyRxBGE5geEvSlQWAB/4sChd?= =?us-ascii?Q?YNe10dTbEwRL1o8IQv2KnDKMwycy9AtYgedsFwCWSmFrIrjrB5hl5wdfWxbR?= =?us-ascii?Q?Gtrpj1EQDmPFXntgURzoifqKcMaDSbaD/tZ5S88Ag7oN1usyXjUO+FPHL3kf?= =?us-ascii?Q?vEkv0IkIp4zUKrJoNXJJAWc1Eis+60zMRzsTyiZ+nqtSNT82yhmRT2KrjURF?= =?us-ascii?Q?9UmR9J9MFrwC4jD0WteWlpzGopI4U2TWOhzM5c5fKhEvb+uAWo8yUgz7+9/Q?= =?us-ascii?Q?y2Xec4L/IBuvlOj0Zh76Hej322FiaJVE2VjDjrx3niYkkCoC995WroqUE/XO?= =?us-ascii?Q?uJ1HcXzvGODykUrALKSnm7+dj4OvztZ51FqbABOHd4NrMKv/5RwbxnYq3UWe?= =?us-ascii?Q?Lw9NeZDVZ87z8sDKDp7OGuSWBTuTq?= X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39860400002)(39450400003)(39410400002)(39400400002)(39850400002)(305945005)(86362001)(5660300001)(6666003)(25786009)(3846002)(6506006)(478600001)(6916009)(2950100002)(36756003)(8676002)(81166006)(189998001)(42186005)(6486002)(38730400002)(110136004)(107886003)(50986999)(48376002)(76176999)(66066001)(2351001)(2906002)(7736002)(47776003)(50466002)(4326008)(6512007)(5003940100001)(2361001)(33646002)(50226002)(6116002)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB320;H:elxacz23q12.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB320;23:qFCVNkBUxmZYPYOjFIdXxsIHw6EKdqpFwNKy6tahxn?= =?us-ascii?Q?pyfxKgNJtXgM38ABaHKsdv/xD5OPmCIvbDzI7Jk5QfA/EIdEKJkdWDZKUPul?= =?us-ascii?Q?AZKgmjRwpN/pVVsKhbzMNOA45Vm6rkugcLS29Bqt4lLDr8dbd6TOwDlttlRG?= =?us-ascii?Q?nu8R+59zaFt2kPT3uRSn7PTXqonlxas8FujgMzQdO1sWZ3VWxIgtpVkSmf2g?= =?us-ascii?Q?yUvGzU55Tgenl2zMt3Eo+zC//E9tKy6M1uyxRMYydhV6J8X5sShTADi0dAdT?= =?us-ascii?Q?tLn5U6QiFxi9XhyyaZ5ixX4SXMKkCyRtJT0CpQ3B6sRlHNUN4BaILVGcioS5?= =?us-ascii?Q?p+Pkg9QPwfdwebbUq7gSE0pYhbhodzEhSMCMcAXFBgxjsb8pXYx+lEQbRS2U?= =?us-ascii?Q?/TsHqzo9k4yxhBXoh/HZ9kY5BjuHCxxhRaYruwr76n5a2s+O+o4Px43T3m74?= =?us-ascii?Q?eImYZ8VJbCFQJm9HKg7QVm9+fiVwAimhjB1UsP3TjQ/cKi2D5jSLSB0kf6fK?= =?us-ascii?Q?FlkE0/fQ/2hW095W53IVEfu62k8myYsaCMI0mt6AYqbTEHd31eNaESKuw7tK?= =?us-ascii?Q?Zohl4jP/dKblY4qX8RcRsL85CgUfMaFmAGnlj51sQ1w61nC83fUdzN/jDRJO?= =?us-ascii?Q?8ewEp1S3StzMf04Ywue4maoprCzm8lHIOzmY6xdr78bprMWMCXPFMd98NeUE?= =?us-ascii?Q?EikEXP6VEOVzCEVxCwXu52QkBXTvN6RliPRI61vnNNi1HVbn76HI2ILyjKiq?= =?us-ascii?Q?yvLNpxwFBpty/3ZLlKpyhIz/OC+CejNALuWxETPYVnNSgWdD513/4Lwy+umD?= =?us-ascii?Q?pShMAQAGdBwWI6IOKnyXxfyaQb45N40Nlw3QtBkLkGDvw4/W4cGl4dCO8uRQ?= =?us-ascii?Q?7Bcpmu61MayVOvU/rNCWKQbWZCJUD4K50hu0l1cKGGdLoX4mYbdSQhcKE6kB?= =?us-ascii?Q?L+ns4ov0EhAOx2EqPwja871Cegtw0X9twE+d+f82xERdyqQ6BAveevcNWsIG?= =?us-ascii?Q?tdJ9aBc5WS/vd5VTjenaYb0uJV1iGZUoOPVl2cNtV0mNtjHUH7TClAL8mY9A?= =?us-ascii?Q?SCFyTDRokHtr0I0m8NK+huxbAN?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB320;6:hdJbxl1Ar5EZVV/QKnH5AiNBCiHDORn+6mLr7OunBHp?= =?us-ascii?Q?oB2jxQf+ihF65boiedFfinFCNe/vAHQCKi/HtVoy2bwnR9h3QMu/Twp/5iLP?= =?us-ascii?Q?qHWzB8yhNWqVeZ8Sf4bwRXn6kmYMhiHpjgLUZSvwPJIXptyye0uD/KX4qhYx?= =?us-ascii?Q?dZO6ZDescqg9DobIOyJ6m/Ma76oNS1qdKEMon4tyXKm04PAZhjVpcoLCATeo?= =?us-ascii?Q?b7Z+f+y9AXNvI3hwu56s6+ObfVKRVCJ4bbVIq+umLmHp2zNVfDtMMqmN6Qfn?= =?us-ascii?Q?WWRmp5S0iRniiywN1bS5vlMSNVF8wG8OQ0JAbDXbAWNIoNNKUJYGMVnPRuH4?= =?us-ascii?Q?oqam9anCE7MMbr2Bnh0IOIok98DHFyA/1c6wq+7AXWItXVRP/wAYxB7ad7wE?= =?us-ascii?Q?YNLZuamyjg04xD43a5hU8+bscZWk2Dhk6okmyqhAqB+5LlRJgGLBzUMafnwz?= =?us-ascii?Q?YRkJFIhC/Y4WpKxupmlp7st5cIQUU4u/2kM3KRo5fqZfrZ6XLw1uhlOjxBnV?= =?us-ascii?Q?rFM4z03krca0zBIX/iyQ+7oiD2/IOXYNgnciQRvSUQVG36gmXHhpMzXl7LIi?= =?us-ascii?Q?/nUJujfvOZEXSEpoza+OMIGvHC21jxrImByEhZfa4OCOrLOcoRaEE94kK4Jz?= =?us-ascii?Q?420Ijzqc7InnKn2AS9u/UHXJlvgNK6aIVPt9YJMbq/afPBUcrg8/7DjcQgzo?= =?us-ascii?Q?mGjHYdOEboO2Z9Mlg3KbqP7lJoBhuPGoa4aJV73S92Se+vfsqNCByQVh7cHX?= =?us-ascii?Q?L3VzoRRlBEjn69nIe1CicZJ4B1qK09cAVsct6jpv8+yuZIP1t5MVMnDfXxkm?= =?us-ascii?Q?SPTT3RZgla/yjU3LvnOqEX2hyZLAfPyOksCc5BDGXkojmpBSvaekFU9jhm+b?= =?us-ascii?Q?76zclQu35RFZflMf/X2Yqqj5lN7QDJNkYLkUWk/JPCDoxu89aFuzVG5lA3on?= =?us-ascii?Q?gBfhcxij+joNNSd/OLD8DN/8XrRr9rHONTCdHIvF3Gf/xZZQRXNTonN+NH7Q?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;5:y5LpL6+gfqX+jFcW7G1uSB5vkHKBSJfAflB/qwAyJXsRkTF8yDD5SESj42QXAj650dO2YnJIAtOP4jeMhtA/wfM+Xt42xOmGqWysq37A5KuIOr0Q9Y7yYHtgqqqNa9SWJ4YaGBA3ujS93OdqF603FVZeZ2ca5sl1xRjOP1qFDH3bILxw9KFbnOBqAgzwvXFqRZAecsiD39aLX3G1qJI4P45I2tRmgw7NgXEWM6pX9oxfAnpI696p903Js242XHv1FgO7f/yvawAcO/X/ZdAus0QnzngNV6yZcoYfqfCtFariN5UAk0Pxrd9bOBTAM8wcnC7nlMFzeNIrKmOlrdx/3UWjbRshrCwkyYOIl6m6ZJdb6xjsBE6ZXZ+JxqkttbEVrVfMzGlXQWwRoH11H96z5TgsfY+UkEN3KNlDyWypGey0jsz/DQl/IqWIDRmXpxDBu9lZmaa6JKQKcSlxgOpE9L+1s2T7tqojvkYn7ODT458E0jO+C2+4SjjCVZK7s267;24:MaHE00iP/W9bO7UI89aMyRWo1d3ns7jMRWAH+YKfS/w37nYs7+TWkaEsJeoEQXTxKf+3xm3k8GYD24Sl9AQbi1nvCSD/Y961FD+oNH+eAG0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;7:Am0BYq1uVtNsKyDcG1EGDLvF3cXso9gmKDkIb3a1dEzEhQ6BDNbqQ/XNJ7UeTTI0ne03Xj95d9TDlLBJ+i/U6M2l9VrhPJULtclhBgw13PfnTsu0pV5t78Wuo+nX0DfwnbL1aRSdMeKXP0XKjq6HNBkkKc8Y/byVBQiMeVdhTlPgWLgMg86HyLbd+kx3UK+G34dJQTnFyqPZpz7kBgtlf9LbxaEX+p0QpRd6/P0sPIKVYdLhbiDpxLw+ld45I+6veXw3LW/eQs3bCh24si46wo4ytssSB28bb02xFdiIVUn+SZoFMjPModm1V1SeQpYkDk1v8rFZuig1ARqSVTkZQAFYohFlxfRLc7H6oRJyxU1zOr+S5952yXDs6ne57+Is3QRKzMVcVjqJJ9lCzma4SxkvaidyB+Kfh/xpVQfsVGc0lzoXYEVZyH26L/zdwv2Frf3GHEmMYJdsdJKHqFIn6HsLOvh1BuayI4GgU2n6zBE02i/kcU1BOHyOETHqQcwwesLbDGuefeyQgSSlG+5sqVvEvpEaD3dTzepB2l+p7PF6M0uDaMvlRvL7TP8vW6vX26zF9DEjCrP36JCVZLsqEWeVwgdaND3NBY+F4aBV+BacWu9DDHVfnS9AF3Hdq82qisLgCkz6cXdKG0R04/x2O8YxKXXLKhpKlVfrrGEcTh9bIdRDO0Hp+p2y/UoyL1EEOMDQ8Wd9MX6a7sjYOqQxCG1LuCdsi0sID7hCLu3qCg8OT7J4TG/nKCK179ccBIBBSY/p3L57r0R7y83fcCmCeZykJJCNu6wYKqkroLYiggk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 20:15:19.1536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00604.txt.bz2 This get around this warning given by clang... /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:209:7: error: variable 'i' is incremented both in the loop header and in the loop body [-Werror,-Wfor-loop-analysis] i++; ^ /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:199:32: note: incremented here ALL_DEBUG_ADDRESS_REGISTERS (i) ^ ... I decided in the end to simply print the debug registers one per line. I don't think it particularly helps readability to have them two per line anyway. gdb/ChangeLog: * nat/x86-dregs.c (x86_show_dr): Print registers one per line. --- gdb/nat/x86-dregs.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/gdb/nat/x86-dregs.c b/gdb/nat/x86-dregs.c index 8c8adfa..58b1179 100644 --- a/gdb/nat/x86-dregs.c +++ b/gdb/nat/x86-dregs.c @@ -193,20 +193,16 @@ x86_show_dr (struct x86_debug_reg_state *state, here. */ : "??unknown??")))); debug_printf (":\n"); - debug_printf ("\tCONTROL (DR7): %s STATUS (DR6): %s\n", - phex (state->dr_control_mirror, 8), - phex (state->dr_status_mirror, 8)); + + debug_printf ("\tCONTROL (DR7): 0x%s\n",phex (state->dr_control_mirror, 8)); + debug_printf ("\tSTATUS (DR6): 0x%s\n", phex (state->dr_status_mirror, 8)); + ALL_DEBUG_ADDRESS_REGISTERS (i) { - debug_printf ("\ -\tDR%d: addr=0x%s, ref.count=%d DR%d: addr=0x%s, ref.count=%d\n", + debug_printf ("\tDR%d: addr=0x%s, ref.count=%d\n", i, phex (state->dr_mirror[i], x86_get_debug_register_length ()), - state->dr_ref_count[i], - i + 1, phex (state->dr_mirror[i + 1], - x86_get_debug_register_length ()), - state->dr_ref_count[i + 1]); - i++; + state->dr_ref_count[i]); } } -- 2.7.4