From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>,
Sandra Loosemore <sandra@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: [rfc] PR 20569, segv in follow_exec
Date: Wed, 19 Oct 2016 13:37:00 -0000 [thread overview]
Message-ID: <14a10c11-cda1-945c-560a-ee619fe59101@redhat.com> (raw)
In-Reply-To: <50f4c7d8-44e3-4351-0b54-9cbaef64717a@codesourcery.com>
On 10/18/2016 07:11 PM, Luis Machado wrote:
> I went through the patch and, although this code as a whole is a bit on
> the convoluted side, it looks reasonable to me.
>
> Segfaults are not supposed to happen, so allowing the session to
> continue is a good thing IMO.
>
> Sounds like a good candidate for master and even stable branches.
I didn't look at the patch in detail yet, but I think it'd be
very good to have tests?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-10-19 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 22:51 Sandra Loosemore
2016-10-18 18:11 ` Luis Machado
2016-10-19 13:37 ` Pedro Alves [this message]
2016-10-19 16:14 ` Luis Machado
2016-10-19 20:19 ` Luis Machado
2016-10-20 23:27 ` Pedro Alves
2016-10-21 18:30 ` Luis Machado
2016-10-21 18:33 ` Pedro Alves
2016-10-21 18:34 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14a10c11-cda1-945c-560a-ee619fe59101@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).